✨ add EFS mount option to sidecar

matusdrobuliak66 commented 1 month ago

What do these changes do?

✨ add EFS mount option to sidecar (only if it is enabled for a specific user - this is temporary for testing purpose)

Related issue/s

closes https://github.com/ITISFoundation/osparc-simcore/issues/5872
relates https://github.com/ITISFoundation/osparc-issues/issues/1313

Dev-ops checklist
- New variable EFS_ENABLED_FOR_USERS --> already added to aws master in config repo
- [ ] No ENV changes or I properly updated ENV (read the instruction)

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 77.08333% with 11 lines in your changes missing coverage. Please review.

Project coverage is 80.2%. Comparing base (cafbf96) to head (38f1428). Report is 260 commits behind head on master.

Additional details and impacted files

[![Impacted file tree graph](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5873/graphs/tree.svg?width=650&height=150&src=pr&token=h1rOE8q7ic&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation)](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5873?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) ```diff @@ Coverage Diff @@ ## master #5873 +/- ## ========================================= - Coverage 84.5% 80.2% -4.4% ========================================= Files 10 1404 +1394 Lines 214 57834 +57620 Branches 25 1330 +1305 ========================================= + Hits 181 46422 +46241 - Misses 23 11136 +11113 - Partials 10 276 +266 ``` | [Flag](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5873/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) | Coverage Δ | | |---|---|---| | [integrationtests](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5873/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) | `41.5% <ø> (?)` | | | [unittests](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5873/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) | `79.9% <77.0%> (-4.7%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5873?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) | Coverage Δ | | |---|---|---| | [...abbitmq/rpc\_interfaces/efs\_guardian/efs\_manager.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5873?src=pr&el=tree&filepath=packages%2Fservice-library%2Fsrc%2Fservicelib%2Frabbitmq%2Frpc_interfaces%2Fefs_guardian%2Fefs_manager.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-cGFja2FnZXMvc2VydmljZS1saWJyYXJ5L3NyYy9zZXJ2aWNlbGliL3JhYmJpdG1xL3JwY19pbnRlcmZhY2VzL2Vmc19ndWFyZGlhbi9lZnNfbWFuYWdlci5weQ==) | `0.0% <ø> (ø)` | | | [...kages/settings-library/src/settings\_library/efs.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5873?src=pr&el=tree&filepath=packages%2Fsettings-library%2Fsrc%2Fsettings_library%2Fefs.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-cGFja2FnZXMvc2V0dGluZ3MtbGlicmFyeS9zcmMvc2V0dGluZ3NfbGlicmFyeS9lZnMucHk=) | `100.0% <100.0%> (ø)` | | | [...ector\_v2/core/dynamic\_services\_settings/sidecar.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5873?src=pr&el=tree&filepath=services%2Fdirector-v2%2Fsrc%2Fsimcore_service_director_v2%2Fcore%2Fdynamic_services_settings%2Fsidecar.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-c2VydmljZXMvZGlyZWN0b3ItdjIvc3JjL3NpbWNvcmVfc2VydmljZV9kaXJlY3Rvcl92Mi9jb3JlL2R5bmFtaWNfc2VydmljZXNfc2V0dGluZ3Mvc2lkZWNhci5weQ==) | `96.1% <100.0%> (ø)` | | | [...core\_service\_efs\_guardian/api/rpc/\_efs\_guardian.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5873?src=pr&el=tree&filepath=services%2Fefs-guardian%2Fsrc%2Fsimcore_service_efs_guardian%2Fapi%2Frpc%2F_efs_guardian.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-c2VydmljZXMvZWZzLWd1YXJkaWFuL3NyYy9zaW1jb3JlX3NlcnZpY2VfZWZzX2d1YXJkaWFuL2FwaS9ycGMvX2Vmc19ndWFyZGlhbi5weQ==) | `100.0% <ø> (ø)` | | | [.../src/simcore\_service\_efs\_guardian/core/settings.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5873?src=pr&el=tree&filepath=services%2Fefs-guardian%2Fsrc%2Fsimcore_service_efs_guardian%2Fcore%2Fsettings.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-c2VydmljZXMvZWZzLWd1YXJkaWFuL3NyYy9zaW1jb3JlX3NlcnZpY2VfZWZzX2d1YXJkaWFuL2NvcmUvc2V0dGluZ3MucHk=) | `97.3% <100.0%> (ø)` | | | [...mcore\_service\_efs\_guardian/services/efs\_manager.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5873?src=pr&el=tree&filepath=services%2Fefs-guardian%2Fsrc%2Fsimcore_service_efs_guardian%2Fservices%2Fefs_manager.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-c2VydmljZXMvZWZzLWd1YXJkaWFuL3NyYy9zaW1jb3JlX3NlcnZpY2VfZWZzX2d1YXJkaWFuL3NlcnZpY2VzL2Vmc19tYW5hZ2VyLnB5) | `100.0% <ø> (ø)` | | | [...service\_efs\_guardian/services/efs\_manager\_setup.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5873?src=pr&el=tree&filepath=services%2Fefs-guardian%2Fsrc%2Fsimcore_service_efs_guardian%2Fservices%2Fefs_manager_setup.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-c2VydmljZXMvZWZzLWd1YXJkaWFuL3NyYy9zaW1jb3JlX3NlcnZpY2VfZWZzX2d1YXJkaWFuL3NlcnZpY2VzL2Vmc19tYW5hZ2VyX3NldHVwLnB5) | `96.0% <100.0%> (ø)` | | | [...\_sidecar/scheduler/\_core/\_event\_create\_sidecars.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5873?src=pr&el=tree&filepath=services%2Fdirector-v2%2Fsrc%2Fsimcore_service_director_v2%2Fmodules%2Fdynamic_sidecar%2Fscheduler%2F_core%2F_event_create_sidecars.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-c2VydmljZXMvZGlyZWN0b3ItdjIvc3JjL3NpbWNvcmVfc2VydmljZV9kaXJlY3Rvcl92Mi9tb2R1bGVzL2R5bmFtaWNfc2lkZWNhci9zY2hlZHVsZXIvX2NvcmUvX2V2ZW50X2NyZWF0ZV9zaWRlY2Fycy5weQ==) | `52.6% <33.3%> (ø)` | | | [...ice\_director\_v2/modules/dynamic\_sidecar/volumes.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5873?src=pr&el=tree&filepath=services%2Fdirector-v2%2Fsrc%2Fsimcore_service_director_v2%2Fmodules%2Fdynamic_sidecar%2Fvolumes.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-c2VydmljZXMvZGlyZWN0b3ItdjIvc3JjL3NpbWNvcmVfc2VydmljZV9kaXJlY3Rvcl92Mi9tb2R1bGVzL2R5bmFtaWNfc2lkZWNhci92b2x1bWVzLnB5) | `64.0% <60.0%> (ø)` | | | [...es/dynamic\_sidecar/docker\_service\_specs/sidecar.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5873?src=pr&el=tree&filepath=services%2Fdirector-v2%2Fsrc%2Fsimcore_service_director_v2%2Fmodules%2Fdynamic_sidecar%2Fdocker_service_specs%2Fsidecar.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-c2VydmljZXMvZGlyZWN0b3ItdjIvc3JjL3NpbWNvcmVfc2VydmljZV9kaXJlY3Rvcl92Mi9tb2R1bGVzL2R5bmFtaWNfc2lkZWNhci9kb2NrZXJfc2VydmljZV9zcGVjcy9zaWRlY2FyLnB5) | `84.6% <66.6%> (ø)` | | ... and [1361 files with indirect coverage changes](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5873/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation)