♻️ refactor `RedisClientsManager` and `RedisClientSDK`

GitHK commented 1 month ago

What do these changes do?

✨ added decode_responses to RedisClientSDK
✨RedisClientsManager initialisation changed to allow for overwriting of default values used in the constructor of RedisClientSDK
♻️ RedisClientSDK clients now expose the health of the connection to Redis.
⚰️ removed HealthCheckedRedisClientSDK and merged with RedisClientSDK

Related issue/s

required by https://github.com/ITISFoundation/osparc-simcore/pull/5892

How to test

Dev-ops checklist

[x] No ENV changes or I properly updated ENV (read the instruction)

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.5%. Comparing base (cafbf96) to head (12c91e6). Report is 265 commits behind head on master.

Additional details and impacted files

[![Impacted file tree graph](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5888/graphs/tree.svg?width=650&height=150&src=pr&token=h1rOE8q7ic&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation)](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5888?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) ```diff @@ Coverage Diff @@ ## master #5888 +/- ## ========================================= + Coverage 84.5% 87.5% +2.9% ========================================= Files 10 1110 +1100 Lines 214 48293 +48079 Branches 25 716 +691 ========================================= + Hits 181 42261 +42080 - Misses 23 5872 +5849 - Partials 10 160 +150 ``` | [Flag](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5888/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) | Coverage Δ | | |---|---|---| | [integrationtests](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5888/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) | `65.3% <100.0%> (?)` | | | [unittests](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5888/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) | `85.2% <100.0%> (+0.6%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5888?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) | Coverage Δ | | |---|---|---| | [...src/servicelib/deferred\_tasks/\_deferred\_manager.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5888?src=pr&el=tree&filepath=packages%2Fservice-library%2Fsrc%2Fservicelib%2Fdeferred_tasks%2F_deferred_manager.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-cGFja2FnZXMvc2VydmljZS1saWJyYXJ5L3NyYy9zZXJ2aWNlbGliL2RlZmVycmVkX3Rhc2tzL19kZWZlcnJlZF9tYW5hZ2VyLnB5) | `89.8% <100.0%> (ø)` | | | [...c/servicelib/deferred\_tasks/\_redis\_task\_tracker.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5888?src=pr&el=tree&filepath=packages%2Fservice-library%2Fsrc%2Fservicelib%2Fdeferred_tasks%2F_redis_task_tracker.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-cGFja2FnZXMvc2VydmljZS1saWJyYXJ5L3NyYy9zZXJ2aWNlbGliL2RlZmVycmVkX3Rhc2tzL19yZWRpc190YXNrX3RyYWNrZXIucHk=) | `100.0% <100.0%> (ø)` | | | [packages/service-library/src/servicelib/redis.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5888?src=pr&el=tree&filepath=packages%2Fservice-library%2Fsrc%2Fservicelib%2Fredis.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-cGFja2FnZXMvc2VydmljZS1saWJyYXJ5L3NyYy9zZXJ2aWNlbGliL3JlZGlzLnB5) | `95.2% <100.0%> (ø)` | | | [...s/service-library/src/servicelib/retry\_policies.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5888?src=pr&el=tree&filepath=packages%2Fservice-library%2Fsrc%2Fservicelib%2Fretry_policies.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-cGFja2FnZXMvc2VydmljZS1saWJyYXJ5L3NyYy9zZXJ2aWNlbGliL3JldHJ5X3BvbGljaWVzLnB5) | `100.0% <100.0%> (ø)` | | | [...2/src/simcore\_service\_director\_v2/modules/redis.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5888?src=pr&el=tree&filepath=services%2Fdirector-v2%2Fsrc%2Fsimcore_service_director_v2%2Fmodules%2Fredis.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-c2VydmljZXMvZGlyZWN0b3ItdjIvc3JjL3NpbWNvcmVfc2VydmljZV9kaXJlY3Rvcl92Mi9tb2R1bGVzL3JlZGlzLnB5) | `100.0% <100.0%> (ø)` | | | [...ervice\_dynamic\_scheduler/api/rest/\_dependencies.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5888?src=pr&el=tree&filepath=services%2Fdynamic-scheduler%2Fsrc%2Fsimcore_service_dynamic_scheduler%2Fapi%2Frest%2F_dependencies.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-c2VydmljZXMvZHluYW1pYy1zY2hlZHVsZXIvc3JjL3NpbWNvcmVfc2VydmljZV9keW5hbWljX3NjaGVkdWxlci9hcGkvcmVzdC9fZGVwZW5kZW5jaWVzLnB5) | `100.0% <100.0%> (ø)` | | | [...core\_service\_dynamic\_scheduler/api/rest/\_health.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5888?src=pr&el=tree&filepath=services%2Fdynamic-scheduler%2Fsrc%2Fsimcore_service_dynamic_scheduler%2Fapi%2Frest%2F_health.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-c2VydmljZXMvZHluYW1pYy1zY2hlZHVsZXIvc3JjL3NpbWNvcmVfc2VydmljZV9keW5hbWljX3NjaGVkdWxlci9hcGkvcmVzdC9faGVhbHRoLnB5) | `100.0% <100.0%> (ø)` | | | [...imcore\_service\_dynamic\_scheduler/services/redis.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5888?src=pr&el=tree&filepath=services%2Fdynamic-scheduler%2Fsrc%2Fsimcore_service_dynamic_scheduler%2Fservices%2Fredis.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-c2VydmljZXMvZHluYW1pYy1zY2hlZHVsZXIvc3JjL3NpbWNvcmVfc2VydmljZV9keW5hbWljX3NjaGVkdWxlci9zZXJ2aWNlcy9yZWRpcy5weQ==) | `100.0% <100.0%> (ø)` | | | [.../web/server/src/simcore\_service\_webserver/redis.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5888?src=pr&el=tree&filepath=services%2Fweb%2Fserver%2Fsrc%2Fsimcore_service_webserver%2Fredis.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-c2VydmljZXMvd2ViL3NlcnZlci9zcmMvc2ltY29yZV9zZXJ2aWNlX3dlYnNlcnZlci9yZWRpcy5weQ==) | `95.6% <100.0%> (ø)` | | ... and [1099 files with indirect coverage changes](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5888/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation)

GitHK commented 1 month ago

@sanderegg @pcrespov I had to rework this PR a bit, please read the updated description again