ITISFoundation / osparc-simcore

🐼 osparc-simcore simulation framework
https://osparc.io
MIT License
44 stars 26 forks source link

✨ Frontend: Expose ``inputs required`` property #5899

Closed odeimaiz closed 1 month ago

odeimaiz commented 1 month ago

What do these changes do?

This PR exposes the node's inputsRequired attribute to the frontend. Users will now be able to make inputs required.

RequiredInputs

Related issue/s

related to https://github.com/ITISFoundation/osparc-simcore/pull/5838 related to https://github.com/ITISFoundation/osparc-simcore/pull/5845

How to test

Dev-ops checklist

odeimaiz commented 1 month ago

Maybe you can add a tooltip saying what happens when you set required.

The tooltip will say: "Required input: Without it, the service will not start/run."

@elisabettai Is that fine?

elisabettai commented 1 month ago

Maybe you can add a tooltip saying what happens when you set required.

The tooltip will say: "Required input: Without it, the service will not start/run."

@elisabettai Is that fine?

It sounds good. I also just noticed that you change the string when the option is selected, and it is a bit confusing (like it was for Service Autostart). I know you don't like a switch button, and without adding a color to it, it might be more confusing. What about:

If you go in that direction, than the tooltip should say: "Mandatory input: without it, the connected service will not start/run"

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

odeimaiz commented 3 weeks ago

For the Release Notes:

RequiredInputs