♻️ Major cleanup of catalog service

pcrespov commented 1 month ago

What do these changes do?

This is a large cleanup refactoring of catalog before modifying its functionality for the related issues mentioned below.

Highlights

♻️ Upgrades to using Annotations
✨ Extends CLI with echo-envfile
🗑️ Removes deprecated local env-devel and extra-docker-compose.yaml
- adapts Makefile and service CLI with echo-envfile command
- simplifies README
♻️ services/catalog/src/simcore_service_catalog/core/background_tasks.py
- move implementation to services
- make sure only one replica runs it
♻️ separated exception classes and handlers
♻️ test fixtures:
- enhanced and reduced tests fixtures by using pytest_simcore assets
♻️ ruffed entire code base

Related issue/s

Follows up from https://github.com/ITISFoundation/osparc-simcore/pull/5902
Preparation for https://github.com/ITISFoundation/osparc-issues/issues/1404

How to test

cd services/catalog
make install-dev
make test-dev-unit

Dev-ops checklist

CATALOG_BACKGROUND_TASK_REST_TIME was missing
Please review https://git.speag.com/oSparc/osparc-ops-deployment-configuration/-/merge_requests/622

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.6%. Comparing base (cafbf96) to head (a2de9fe). Report is 251 commits behind head on master.

Additional details and impacted files

[![Impacted file tree graph](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5904/graphs/tree.svg?width=650&height=150&src=pr&token=h1rOE8q7ic&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation)](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5904?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) ```diff @@ Coverage Diff @@ ## master #5904 +/- ## ========================================= + Coverage 84.5% 88.6% +4.0% ========================================= Files 10 937 +927 Lines 214 41367 +41153 Branches 25 932 +907 ========================================= + Hits 181 36663 +36482 - Misses 23 4495 +4472 - Partials 10 209 +199 ``` | [Flag](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5904/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) | Coverage Δ | | |---|---|---| | [integrationtests](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5904/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) | `64.7% <ø> (?)` | | | [unittests](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5904/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) | `86.3% <ø> (+1.7%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#carryforward-flags-in-the-pull-request-comment) to find out more. [see 913 files with indirect coverage changes](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5904/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation)