ITISFoundation / osparc-simcore

🐼 osparc-simcore simulation framework
https://osparc.io
MIT License
44 stars 26 forks source link

♻️🐛Storage: disable handling of dangling multipart uploads #5978

Closed sanderegg closed 1 week ago

sanderegg commented 1 week ago

What do these changes do?

Related issue/s

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.4%. Comparing base (cafbf96) to head (a03c4a8). Report is 289 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5978/graphs/tree.svg?width=650&height=150&src=pr&token=h1rOE8q7ic&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation)](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5978?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) ```diff @@ Coverage Diff @@ ## master #5978 +/- ## ========================================= - Coverage 84.5% 66.4% -18.2% ========================================= Files 10 599 +589 Lines 214 30403 +30189 Branches 25 205 +180 ========================================= + Hits 181 20205 +20024 - Misses 23 10147 +10124 - Partials 10 51 +41 ``` | [Flag](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5978/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) | Coverage Δ | | |---|---|---| | [integrationtests](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5978/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) | `64.7% <ø> (?)` | | | [unittests](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5978/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) | `91.5% <100.0%> (+6.9%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5978?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) | Coverage Δ | | |---|---|---| | [...rage/src/simcore\_service\_storage/simcore\_s3\_dsm.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5978?src=pr&el=tree&filepath=services%2Fstorage%2Fsrc%2Fsimcore_service_storage%2Fsimcore_s3_dsm.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-c2VydmljZXMvc3RvcmFnZS9zcmMvc2ltY29yZV9zZXJ2aWNlX3N0b3JhZ2Uvc2ltY29yZV9zM19kc20ucHk=) | `94.3% <100.0%> (ø)` | | ... and [608 files with indirect coverage changes](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5978/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation)
sanderegg commented 1 week ago

So we need ITISFoundation/osparc-ops-environments#702 to merge firsts, right?

@pcrespov not really, as how I understand it, the AWS rule will abort any multipart upload older than a few days (which time we can choose)