search

ITISFoundation / osparc-simcore

🐼 osparc-simcore simulation framework
https://osparc.io
MIT License
43 stars 27 forks source link

✨ Implementing new `list_services_paginated` entrypoint in web-api (part 1) #5991

Closed pcrespov closed 2 months ago

pcrespov commented 3 months ago

What do these changes do?

In PR https://github.com/ITISFoundation/osparc-simcore/pull/6003 we implemented a new rpc interface in the catalog and connected it with the rest api of the webserver service. This PR partially implements api.rpc._services.list_services_paginated.

Specifically:

Following up PRs will cover:

Related issue/s

How to test

Driving tests

Dev-ops checklist

None

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 95.29412% with 8 lines in your changes missing coverage. Please review.

Project coverage is 87.7%. Comparing base (cafbf96) to head (1550b6c). Report is 319 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5991/graphs/tree.svg?width=650&height=150&src=pr&token=h1rOE8q7ic&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation)](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5991?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) ```diff @@ Coverage Diff @@ ## master #5991 +/- ## ========================================= + Coverage 84.5% 87.7% +3.2% ========================================= Files 10 1289 +1279 Lines 214 55418 +55204 Branches 25 1101 +1076 ========================================= + Hits 181 48648 +48467 - Misses 23 6531 +6508 - Partials 10 239 +229 ``` | [Flag](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5991/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) | Coverage Δ | | |---|---|---| | [integrationtests](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5991/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) | `64.7% <ø> (?)` | | | [unittests](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5991/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) | `85.7% <95.2%> (+1.1%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5991?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) | Coverage Δ | | |---|---|---| | [...src/models\_library/api\_schemas\_catalog/services.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5991?src=pr&el=tree&filepath=packages%2Fmodels-library%2Fsrc%2Fmodels_library%2Fapi_schemas_catalog%2Fservices.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-cGFja2FnZXMvbW9kZWxzLWxpYnJhcnkvc3JjL21vZGVsc19saWJyYXJ5L2FwaV9zY2hlbWFzX2NhdGFsb2cvc2VydmljZXMucHk=) | `100.0% <100.0%> (ø)` | | | [...dels-library/src/models\_library/services\_access.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5991?src=pr&el=tree&filepath=packages%2Fmodels-library%2Fsrc%2Fmodels_library%2Fservices_access.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-cGFja2FnZXMvbW9kZWxzLWxpYnJhcnkvc3JjL21vZGVsc19saWJyYXJ5L3NlcnZpY2VzX2FjY2Vzcy5weQ==) | `100.0% <ø> (ø)` | | | [...s-library/src/models\_library/services\_authoring.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5991?src=pr&el=tree&filepath=packages%2Fmodels-library%2Fsrc%2Fmodels_library%2Fservices_authoring.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-cGFja2FnZXMvbW9kZWxzLWxpYnJhcnkvc3JjL21vZGVsc19saWJyYXJ5L3NlcnZpY2VzX2F1dGhvcmluZy5weQ==) | `100.0% <100.0%> (ø)` | | | [...els-library/src/models\_library/services\_history.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5991?src=pr&el=tree&filepath=packages%2Fmodels-library%2Fsrc%2Fmodels_library%2Fservices_history.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-cGFja2FnZXMvbW9kZWxzLWxpYnJhcnkvc3JjL21vZGVsc19saWJyYXJ5L3NlcnZpY2VzX2hpc3RvcnkucHk=) | `100.0% <100.0%> (ø)` | | | [...icelib/rabbitmq/rpc\_interfaces/catalog/services.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5991?src=pr&el=tree&filepath=packages%2Fservice-library%2Fsrc%2Fservicelib%2Frabbitmq%2Frpc_interfaces%2Fcatalog%2Fservices.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-cGFja2FnZXMvc2VydmljZS1saWJyYXJ5L3NyYy9zZXJ2aWNlbGliL3JhYmJpdG1xL3JwY19pbnRlcmZhY2VzL2NhdGFsb2cvc2VydmljZXMucHk=) | `0.0% <ø> (ø)` | | | [.../src/simcore\_service\_catalog/api/rest/\_services.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5991?src=pr&el=tree&filepath=services%2Fcatalog%2Fsrc%2Fsimcore_service_catalog%2Fapi%2Frest%2F_services.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-c2VydmljZXMvY2F0YWxvZy9zcmMvc2ltY29yZV9zZXJ2aWNlX2NhdGFsb2cvYXBpL3Jlc3QvX3NlcnZpY2VzLnB5) | `59.3% <100.0%> (ø)` | | | [...ervice\_catalog/api/rest/\_services\_access\_rights.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5991?src=pr&el=tree&filepath=services%2Fcatalog%2Fsrc%2Fsimcore_service_catalog%2Fapi%2Frest%2F_services_access_rights.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-c2VydmljZXMvY2F0YWxvZy9zcmMvc2ltY29yZV9zZXJ2aWNlX2NhdGFsb2cvYXBpL3Jlc3QvX3NlcnZpY2VzX2FjY2Vzc19yaWdodHMucHk=) | `100.0% <100.0%> (ø)` | | | [...g/src/simcore\_service\_catalog/api/rpc/\_services.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5991?src=pr&el=tree&filepath=services%2Fcatalog%2Fsrc%2Fsimcore_service_catalog%2Fapi%2Frpc%2F_services.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-c2VydmljZXMvY2F0YWxvZy9zcmMvc2ltY29yZV9zZXJ2aWNlX2NhdGFsb2cvYXBpL3JwYy9fc2VydmljZXMucHk=) | `100.0% <100.0%> (ø)` | | | [...e\_service\_catalog/db/repositories/\_services\_sql.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5991?src=pr&el=tree&filepath=services%2Fcatalog%2Fsrc%2Fsimcore_service_catalog%2Fdb%2Frepositories%2F_services_sql.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-c2VydmljZXMvY2F0YWxvZy9zcmMvc2ltY29yZV9zZXJ2aWNlX2NhdGFsb2cvZGIvcmVwb3NpdG9yaWVzL19zZXJ2aWNlc19zcWwucHk=) | `100.0% <100.0%> (ø)` | | | [.../simcore\_service\_catalog/db/repositories/groups.py](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5991?src=pr&el=tree&filepath=services%2Fcatalog%2Fsrc%2Fsimcore_service_catalog%2Fdb%2Frepositories%2Fgroups.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation#diff-c2VydmljZXMvY2F0YWxvZy9zcmMvc2ltY29yZV9zZXJ2aWNlX2NhdGFsb2cvZGIvcmVwb3NpdG9yaWVzL2dyb3Vwcy5weQ==) | `56.7% <100.0%> (ø)` | | | ... and [5 more](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5991?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation) | | ... and [1267 files with indirect coverage changes](https://app.codecov.io/gh/ITISFoundation/osparc-simcore/pull/5991/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ITISFoundation)