ITISFoundation / osparc-simcore

🐼 osparc-simcore simulation framework
https://osparc.io
MIT License
43 stars 27 forks source link

♻️🐛 [Frontend] Reuse iframe starting sequence for guests #6004

Closed odeimaiz closed 3 months ago

odeimaiz commented 3 months ago

What do these changes do?

The Dynamic Service starting sequence (poll state, show loading sequence, handle errors, switch to iframe's content...) wasn't the same for logged in users and guest users. This PR unifies the code related to it.

Bonus: Switch to Voila loading content, instead of staying at the Ready loading page, without waiting for the native "load" event.

@Konohana0608 I also found the way to tune the Running 2 of 5... loading voila message. Notice the Sleeping for 30" message:

VoilaMessages

Guest

Related issue/s

How to test

Dev-ops checklist

odeimaiz commented 3 months ago

Very nice, thanks! I also want to see the trick to tune the voila loading messages. 🤩

@elisabettai

Add the following cell before running the cell that is going to take long

%%js
const loadingTextEl = document.getElementById("loading_text");
loadingTextEl ? loadingTextEl.innerText = 'This task is going to take very long' : null;

Here we just change the text, but you could also add some fancy HTML 👌