ITISFoundation / osparc-simcore

🐼 osparc-simcore simulation framework
https://osparc.io
MIT License
43 stars 27 forks source link

✨ [Frontend] Use new ``/dev/services`` endpoint and its new metadata #6016

Closed odeimaiz closed 1 month ago

odeimaiz commented 2 months ago

What do these changes do?

New /dev/services:

New metadata:

Related issue/s

related to https://github.com/ITISFoundation/osparc-issues/issues/1404

How to test

Dev-ops checklist

odeimaiz commented 1 month ago

Very nice.

Q1: Is the old GUI still active (i.e. keep old and new versions) or after this PR, the new is taking over. If the latter, we must point to non-dev entrypoints before we merge this to master!

Q2: How does this compare in speed wrt to the old version?

@pcrespov

A1: The latter. So, yes, I need your change in https://github.com/ITISFoundation/osparc-simcore/pull/6084 also to make the tests here green, thanks.

A2: Tricky question. First of all, I didn't have the feeling the waiting time for my user was long. Before, we were fetching all the services metadata at once and that endpoint wouldn't be used again. Now, we fetch only the latest version metadata and the whole history of the service (which already brings new features) at start up, and later, only when necessary, other version's metadata. This follow up calls are not noticeable for the user. So, I believe, it's fare to make the comparison between the old /services and the new /dev/services/-/latest calls. Since @mguidon, has access to many versions in many services, therefor long waiting times, he might be the best user to tell us how much this new endpoint improves the UX.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud