search

ITISFoundation / osparc-simcore

🐼 osparc-simcore simulation framework
https://osparc.io
MIT License
43 stars 27 forks source link

Add test upload large files #6422

Open YuryHrytsuk opened 1 month ago

YuryHrytsuk commented 1 month ago

Background

After migrating to Traefik v2 --> v3, the upload of large files (>1G) got broken due to some timeouts (HTTP Code 499) We caught this error only on STAG and it was too late.

We need to add a test in master so that we catch it early on.

People who have been fixing this bug @matusdrobuliak66 @mrnicegyu11. Talk to them for more info

matusdrobuliak66 commented 1 month ago

During the App team's testing phase, someone noticed that uploading files directly to Sim4Life wasn't working. Why? Because Sim4Life uses PATCH for uploads and expects no timeouts. With the Traefik version change, the default 60-second timeout was introduced. This needed to be overridden to resolve the issue.

By the way, I'm not sure if it's a good practice to test heavy workflows, such as uploading large files, in the master branch. I agree we should have automated tests for that, but I would suggest that these tests only run in staging, always after staging is redeployed. We can gradually add more heavy tests there. What do you think?

sanderegg commented 1 month ago

During the App team's testing phase, someone noticed that uploading files directly to Sim4Life wasn't working. Why? Because Sim4Life uses PATCH for uploads and expects no timeouts. With the Traefik version change, the default 60-second timeout was introduced. This needed to be overridden to resolve the issue.

By the way, I'm not sure if it's a good practice to test heavy workflows, such as uploading large files, in the master branch. I agree we should have automated tests for that, but I would suggest that these tests only run in staging, always after staging is redeployed. We can gradually add more heavy tests there. What do you think?

@matusdrobuliak66 I am not sure I understand why we should wait for staging to discover problems. From my point of view we do not need staging anymore, just for temporary tests where we want people to not be bothered by the constant changes in master. I prefer to fix things right away that discover them after a week or more.