ITISFoundation / osparc-simcore

🐼 osparc-simcore simulation framework
https://osparc.io
MIT License
46 stars 27 forks source link

🎨 [Frontend] Check all linked nodes exist before loading Study #6762

Closed odeimaiz closed 1 week ago

odeimaiz commented 1 week ago

What do these changes do?

It can happen (@AntoninoMarioC), still not sure how, that some node inputs point to nodes that do not exist, making the deserialization of the Study when opening it buggy. This PR checks the links before opening a Study and if it finds any mismatch it will block the Study from being open.

Corrupt

Related issue/s

How to test

Dev-ops checklist

odeimaiz commented 1 week ago

Thanks! 👍 In my opinion, blocking the study from being opened is a rather harsh solution. I would prefer to remove the corrupted links and display a warning message instead. What if the user needs to open the project to download some data? I wouldn’t prohibit that unless opening the project itself would also be corrupted due to the issue.

@matusdrobuliak66 Users can still download the data from the Study Data page, and yes if they open a corrupt study things might get worse.

odeimaiz commented 1 week ago

@matusdrobuliak66 Fix and continue could still be an option we provide, making clear that some links will be removed.

sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud