search

ITISFoundation / publication-IEC62209

📝 A Gaussian-process-model-based approach for robust, independent, and implementation-agnostic validation of complex multi-variable measurement systems: application to SAR measurement systems
GNU General Public License v3.0
0 stars 1 forks source link

Measurement area limited to 80 x 160mm, while entered values were 109 x 228mm #50

Closed njain76 closed 1 year ago

njain76 commented 1 year ago

TrainingData.csv image

Hi,

Although we enter 109 x 229mm for the measurement area, the training data generated is limited to a 80 x 160mm area.

When this training data is fed back to generate the model, the measurement area gets limited to 84 x 168mm, and the user is not allowed to increase the area beyond these values.

Perhaps the measurement area has been reduced, considering the 21mm edge of the 10g cube?

Regards, Nitin

cbujard commented 1 year ago

The second part is perfectly normal. The first part is a bug. @SCA-ZMT can you check the right parameters are properly passed to the Sampler instance that generates the training set (it has to be a new insurance btw). I'll check on my side as well.

cbujard commented 1 year ago

So I just checked: in the core part there is no size issue. When the sampler class is instanciated, the desired xmax and ymax values have to be specified as arguments to the constructor (without these the default is 80 x 160 as observed by Nitin). @odeimaiz does the above corrects this issue?