Backpacks/container weight issue

[GoogleCodeExporter]

What steps will reproduce the problem?
1.make a backpack and place it on the ground and weight is 400 stone max.
2.pick up and place in your backpack and weight goes to 550 stone max.
3.put the backpack back on the ground and max weight goes back to 400
stones even if you have loaded it up to the max of 550 while in your
backpack on your paperdoll.(Properties shows "(however many items
inside)/125 Items 550/400 Stones)

What is the expected output? What do you see instead?
Well...kinda guessing this might cause issues. If it has no way of crashing
a server, I really don't care.I looked at container.cs from RunUO and from
Mal, the root parent is in RunUO, Mals seems to be short and to the point.
But both have the same issue - over max weight when removed from player
backpacks if more them 400 stones is in the container.

What version of the product are you using?
RunUO 319 ML47 - the latest of both.

Please provide any additional information below.
If this really is not an issue that is going to cause bad things to happen,
eh, fine with me, just want to be sure :]

Koluch

Original issue reported on code.google.com by ShazzySh...@gmail.com on 30 May 2009 at 3:36

[GoogleCodeExporter]

Clarification: This deal with all containers that fall under the BaseContainer
definition. Backpacks keep there 550 stones where as things like pouches,, gift
boxes, etc., which are all subclass BaseContainer do not when removed from the 
player
backpack.

Original comment by ShazzySh...@gmail.com on 30 May 2009 at 6:08

[GoogleCodeExporter]

This is not due to MalGanis.  This is a RunUO thing....

This is taken from the core files in RunUO....

Container.cs core file states this....
private static int m_GlobalMaxWeight = 400;

and this is taken from the Backpack script....
        public override int DefaultMaxWeight
        {
            get
            {
                if (Core.ML)
                {
                    Mobile m = ParentEntity as Mobile;
                    if (m != null && m.Backpack == this)
                    {
                        return 550;
                    }
                    else
                    {
                        return base.DefaultMaxWeight;
                    }
                }
                else
                {
                    return base.DefaultMaxWeight;
                }
            }
        }

According to the backpack script the only time it should max weight 550 is when 
in
players pack or is players backpack.

I think that RunUO Devs meant for only the players backpack should have max 
weight of
550 and not containers within players pack.

Original comment by ShaiTanMalkier@gmail.com on 30 May 2009 at 10:36

[GoogleCodeExporter]

I agree, the RunUO code, because of container.cs in the core is incorrect.

Original comment by ShazzySh...@gmail.com on 31 May 2009 at 11:27

[GoogleCodeExporter]

Since it's a RunUO Core thing you should post it on RunUO Just a thought. That 
way if
Mark forgot something then he can update it. 

Original comment by uorevolu...@gmail.com on 2 Jun 2009 at 10:24

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

fixed in the runuo 333 svn.

Original comment by ShazzySh...@gmail.com on 29 Jun 2009 at 2:33

[GoogleCodeExporter]

Original comment by gje...@gmail.com on 4 Jul 2009 at 3:39

• Changed state: Fixed