Shields not being enhanced by DullCopper and higher ingots.

[GoogleCodeExporter]

What steps will reproduce the problem?
1.Crafting a shield using metal resources.
2.Metal shield only retaining original resistance values.
3.Metal shields not upgrading to new resource properties.  Only Hue and
name is changed.

What is the expected output? What do you see instead?
Shield being enhanced by resource.

What version of the product are you using?
newest release.

Please provide any additional information below.
Shields should take resource enhancements.  currently they don't.  Should
this section of code be in the WoodenShield.cs instead of BaseShield.cs?
        #region Mondain's Legacy
        public override int PhysicalResistance{ get{ return
BasePhysicalResistance + GetProtOffset() +
GetResourceAttrs().ShieldPhysicalResist + PhysicalBonus + (SetEquipped ?
SetPhysicalBonus : 0 ); } }
        public override int FireResistance{ get{ return BaseFireResistance +
GetProtOffset() + GetResourceAttrs().ShieldFireResist + FireBonus +
(SetEquipped ? SetFireBonus : 0 ); } }
        public override int ColdResistance{ get{ return BaseColdResistance +
GetProtOffset() + GetResourceAttrs().ShieldColdResist + ColdBonus +
(SetEquipped ? SetColdBonus : 0 ); } }
        public override int PoisonResistance{ get{ return BasePoisonResistance +
GetProtOffset() + GetResourceAttrs().ShieldPoisonResist + PoisonBonus +
(SetEquipped ? SetPoisonBonus : 0 ); } }
        public override int EnergyResistance{ get{ return BaseEnergyResistance +
GetProtOffset() + GetResourceAttrs().ShieldEnergyResist + EnergyBonus +
(SetEquipped ? SetEnergyBonus : 0 ); } }
        #endregion?

Original issue reported on code.google.com by ShaiTanMalkier@gmail.com on 15 Jul 2009 at 9:22

[GoogleCodeExporter]

Line 209 should look like this: if ( !craftItem.ForceNonExceptional ) (note !)

Original comment by gje...@gmail.com on 16 Jul 2009 at 8:29

• Changed state: Accepted

[GoogleCodeExporter]

Ya I got that.  That's not the problem.

This code is located in BaseShield.cs

        #region Mondain's Legacy
        public override int PhysicalResistance { get { return BasePhysicalResistance
+ GetProtOffset() + GetResourceAttrs().ShieldPhysicalResist + PhysicalBonus +
(SetEquipped ? SetPhysicalBonus : 0); } }
        public override int FireResistance { get { return BaseFireResistance +
GetProtOffset() + GetResourceAttrs().ShieldFireResist + FireBonus + 
(SetEquipped ?
SetFireBonus : 0); } }
        public override int ColdResistance { get { return BaseColdResistance +
GetProtOffset() + GetResourceAttrs().ShieldColdResist + ColdBonus + 
(SetEquipped ?
SetColdBonus : 0); } }
        public override int PoisonResistance { get { return BasePoisonResistance +
GetProtOffset() + GetResourceAttrs().ShieldPoisonResist + PoisonBonus + 
(SetEquipped
? SetPoisonBonus : 0); } }
        public override int EnergyResistance { get { return BaseEnergyResistance +
GetProtOffset() + GetResourceAttrs().ShieldEnergyResist + EnergyBonus + 
(SetEquipped
? SetEnergyBonus : 0); } }
        #endregion

Shouldn't it belong in WoodenShield.cs?

If you craft a metal shield with other than Iron Ingots such as Valroite Ingots 
it
should boost the resistance values based on ingots used. And according to that
section I posted the ShieldResistances are for the ML Wood types not Ingot 
types.

Best way to explain it is craft a Valorite Shield. Comment out that section in
BaseShield and restart server. You will notice that resistances change based on 
what
type of ingots used.

That section should only apply to Wooden shields as seen below...

            oak.ShieldPhysicalResist = 1;
            oak.ShieldFireResist = 1;
            oak.ShieldColdResist = 1;
            oak.ShieldPoisonResist = 1;
            oak.ShieldEnergyResist = 1;

The way the first code is written and where it is located it affects all shields
including metal ones. And since there is no Shield****Resist in any of the Metal
Ingot types any bonuses It would of gotten is void due to that section.

Original comment by ShaiTanMalkier@gmail.com on 18 Jul 2009 at 6:51

[GoogleCodeExporter]

Hey Callandor2k i talked to Malganis today and now he knows this issue.

Original comment by uorevolu...@gmail.com on 18 Jul 2009 at 10:22

[GoogleCodeExporter]

Fixed in SVN 50.

Original comment by gje...@gmail.com on 28 Jul 2009 at 10:28

• Changed state: Fixed