ITRS-Group / cordial

Cordial comprises a set of interrelated programs, integrations, libraries and packages for Geneos, principally written in Go.
Other
7 stars 0 forks source link

When you change the port of your gateway using the "geneos set gateway <gateway_name> port=xxxx" command #152

Closed pgalbavy-itrs closed 1 year ago

pgalbavy-itrs commented 1 year ago
          Another observation. After using this new version of the Geneos utility, there seems to be an issue when you change the port of your gateway using the "geneos set gateway <gateway_name> port=xxxx" command.

My test gateway initially got assigned the default 7039 port and I was able to start my gateway with it.

-bash-4.2$ geneos ls Type Names Host Flag Port Version Home gateway test_gateway A localhost 7039 active_prod:6.2.0 /home/geneos/gateway/gateways/test_gateway

However, I tried updating my port from 7039 to 7040 using the "geneos set gateway port=xxxx" command."

-bash-4.2$ geneos set gateway test_gateway port=7040

The command seem to update the port when you run the "geneos ps" or "geneos show gateway" command.

-bash-4.2$ geneos ls Type Names Host Flag Port Version Home gateway test_gateway A localhost 7040 active_prod:6.2.0 /home/geneos/gateway/gateways/test_gateway

-bash-4.2$ geneos show gateway test_gateway | grep port "port": "7040",

However, the in the instance.setup.xml doesn't get updated.

-bash-4.2$ pwd /home/geneos/gateway/gateways/test_gateway -bash-4.2$ grep -i port instance.setup.xml

7039

I was able to find this out as I was not able to start my gateway after updating my port from 7039 to 7040.

Originally posted by @gadvincula in https://github.com/ITRS-Group/cordial/issues/148#issuecomment-1606581344

pgalbavy-itrs commented 1 year ago

This is expected behaviour. Currently you have to explicitly rebuild the configs - this is to avoid unexpected changes.

Setting the gateway port is unusual in that it is a gateway configuration file change and not a command line option change, unlike other components.

It may be a good approach to kick off an automatic rebuild after setting certain values (or even all values) for instances that have marked config::rebuild=always and/or instance config files for gateways, as this is hardwired anyway - this being the intent of the user.

Will add it to work to do.