Limit logs from nodes when all-nodes parameter is used

ITRS-Group / monitor-merlin

Module for Effortless Redundancy and Loadbalancing In Naemon

https://itrs-group.github.io/monitor-merlin/

GNU General Public License v2.0

22 stars 14 forks source link

Limit logs from nodes when all-nodes parameter is used #157

Closed jdumalaonITRS closed 8 months ago

jdumalaonITRS commented 8 months ago

This commit uses the provided --first, --last and --limit parameter values from the command line to extract logs from all nodes based on a limit instead of extracting all logs. This will reduce the disk space usage since Ninja will display 7 days by default.

This is part of MON-13363.

Signed-off-by: Jerson Dumalaon jdumalaon@itrsgroup.com

euniceremoquillo commented 8 months ago

Installed Merlin updates with ninja updates (https://github.com/ITRS-Group/monitor-ninja/pull/314) Go to Report > Event Log. Logs were displayed as expected (Based on Date today -1week) Check "Show logs from all nodes". Logs were displayed as expected. Clear First time input. Returns empty list.

Installed Merlin updates without ninja update. Go to Report > Event Log. Logs were displayed as expected (Based on Limit). Check "Show logs from all nodes". Returns empty list. Input date on First time input. Logs were displayed as expected.

jdumalaonITRS commented 8 months ago

Installed Merlin updates with ninja updates (ITRS-Group/monitor-ninja#314) Go to Report > Event Log. Logs were displayed as expected (Based on Date today -1week) Check "Show logs from all nodes". Logs were displayed as expected. Clear First time input. Returns empty list.

Installed Merlin updates without ninja update. Go to Report > Event Log. Logs were displayed as expected (Based on Limit). Check "Show logs from all nodes". Returns empty list. Input date on First time input. Logs were displayed as expected.

I can't seem to reproduce this. What was the command given from ninja?

euniceremoquillo commented 8 months ago

Installed Merlin updates with ninja updates (ITRS-Group/monitor-ninja#314) Go to Report > Event Log. Logs were displayed as expected (Based on Date today -1week) Check "Show logs from all nodes". Logs were displayed as expected. Clear First time input. Returns empty list. Installed Merlin updates without ninja update. Go to Report > Event Log. Logs were displayed as expected (Based on Limit). Check "Show logs from all nodes". Returns empty list. Input date on First time input. Logs were displayed as expected.

I can't seem to reproduce this. What was the command given from ninja?

Tried it again but on a fresh machine. Works as expected. Disregard earlier comment.