ITRS-Group / monitor-merlin

Module for Effortless Redundancy and Loadbalancing In Naemon
https://itrs-group.github.io/monitor-merlin/
GNU General Public License v2.0
22 stars 14 forks source link

Use check_op5_license instead to validate #76

Closed lgrn closed 4 years ago

lgrn commented 4 years ago

This command was previously severely outdated as we no longer use XML licenses, leading to customer complaints that we are shipping a defective command. There's probably more things we can do here, and 14 days is arbitrary, but since the plugin this depends on needs either days left or amount of hosts to work, the choice here was either to check if days left was <0 or <N. I elected to choose an arbitrary number instead because I can't figure out a valid use case for when you would want a license with less than 14 days to still be marked as OK. If this doesn't make sense, we can change it later, but at least "mon sysconf check license" now works.

kdnilsson commented 4 years ago

@lgrn please add a reference to the ticket MON-12409 at the bottom of the commit message. Something like "This fixes: MON-12409". Good for traceability.

lgrn commented 4 years ago

@lgrn please add a reference to the ticket MON-12409 at the bottom of the commit message. Something like "This fixes: MON-12409". Good for traceability.

Fixed