ITRS-Group / monitor-ninja

Ninja is Now Just Awesome - a modern web GUI for Naemon
Other
32 stars 16 forks source link

Removed show logs from all nodes checkbox #315

Open euniceremoquillo opened 11 months ago

euniceremoquillo commented 11 months ago

This commit removes the show all logs from nodes checkbox on the gui. The show logs from all nodes function should still work via cmd line.

This resolves MON-13363.

Signed-off-by: Eunice Remoquillo eremoquillo@itrsgroup.com

jdumalaonITRS commented 11 months ago

Based on Ninja code, there seems to be already a methid to determine if a user has writes to access show log via: $this->_verify_access('ninja.showlog:read.showlog');

e.g. monitor-ninja/modules/monitoring/controllers/showlog.php:102

I think we need to explore ths some more and check how to add similar functionality to show log for all nodes.

euniceremoquillo commented 11 months ago

Based on Ninja code, there seems to be already a methid to determine if a user has writes to access show log via: $this->_verify_access('ninja.showlog:read.showlog');

e.g. monitor-ninja/modules/monitoring/controllers/showlog.php:102

I think we need to explore ths some more and check how to add similar functionality to show log for all nodes.

Will be taking a look at this one. The UI config for this can be added to the Process Information Page (image attached in the ticket description)