Should deal with files from the SFTP server

[tg137]

The document on the RDG website about timetable data references a Data Transformation and Distribution Service (DTD). See section 7 of this document.

The data that comes from the SFTP server is in a slightly different format than that being downloaded directly from the RDG site itself.

It causes the following specific issues with UK2GTFS:

• The zip file is all uppercase meaning that UK2GTFS doesn't recognise it as a .zip. A simple tolower on the filename given could fix this.
• Each filename within the zip itself is uppercase meaning that when UK2GTFS looks for the .flf", ".mca" and ".msn" files, it can't find them because of a casing issue. Again, a simple tolower should be able to fix this.
• The "dat", "msn", "flf" and "set" files in the ZIP all have 5 lines of comment at the top of them (i.e // Metadata for the file) which causes problems when UK2GTFS starts to parse them. I guess this could be solved by ignoring lines starting with //.

Let me know if you want me to get an example ZIP to you from the SFTP server (although it's a really useful service to sign up for regardless!).

[mem48]

I'll look into this as it doesn't sound too hard to fix and would add useful functionality. If you wanted to make a pull request that would be very helpful.

[mem48]

@tg137 I've looked at the document, I don't think the SFTP server is publically accessible. If you can upload an example file I will have a look, but I can't promise onging support for a private dataset.

[tg137]

Hi @mem48, thanks for taking a look, understand you not wanting to provide ongoing support for this. I've been meaning to take a look at doing a PR but been snowed under recently.

Thanks a lot for adding nr2gtfs, extremely useful.

[mem48]

I'm trying to get the package cleaned up for peer review and a CRAN release, and its difficult for reviewers to test things that they can't access.

A PR sounds the best solution, the changes you suggest are minor and would make the package more usable for more people.

Out of interest are there any other differences to the sftp version that make you want to use it?