Closed stupidpupil closed 2 years ago
So is the fix just to add "R" to the list?
That's what I've done in my fork and seems to be working alright. I guess I should also add an entry to activity_codes
.
Yes, the activity_codes
are a pain as there are so many, and no easy way to check them. The lookup table is an inelegant solution, but will need to have all variants including an "R" added.
I've committed a new way to handle activity codes, which should fix the old Unknown Activity Code
message and now also give a GTFS pickup
and drop_off
code of 3 to stops with an R
code. Let me know if this gives the expected results.
I think that "request only stops" can just have the CIF activity code "R". At the moment, these are being dropped by atoc2gtfs as far as I can tell.
I believe that only necessary change is at: https://github.com/ITSLeeds/UK2GTFS/blob/1a8cde20af5c3e11c65196e05ea3d73b4ebb86e0/R/atoc_import.R#L414-L419
But I thought I should ask before I attempt to tackle this!
Example