Closed stupidpupil closed 2 years ago
Is this from the Coaches dataset, these sometimes seem to have missing data that causes problems.
I'll double-check but I think it's from the W(ales) zip.
I confirm it's "Wales" rather than NCSD. (It's one of the Snowdon Sherpa branded services.)
I've found the problem. Its a edge case where the serviced organsiation has both working day and holiday service patterns. I'm working on a fix.
Current solution may have hidden a bug that this has revealed. The current code assumes that a servied organisation includes services during workdays and excludes them during holidays. But it could be the otherway round. The new method makes and explicit check for inclusion/exclusion and workday/holiday.
I've committed a fix. Seems to work in a few different regions. Let me know if you have any trouble.
Seems to have fixed S1!
However, I'm getting the following error on a few files:
if (ExEndTime >= ExStartTime) { : missing value where TRUE/FALSE needed
which I think might be a new and related problem. Will try to investigate when I can.
Fixing one bug has revealed a few knock-on errors. I've made a few commits already and have some more to do.
I think they are all fixed now. I've added your examples to the set of files used in automated testing https://github.com/ITSLeeds/UK2GTFS/releases/tag/0.002
Trying to convert GwynforCoachesS1-Llanberis-Pen-y-Pass1_TXC_2021825-0748_GCAS001.xml.zip results in the following error:
I've not yet had any luck working out what the underlying issue is.