search

ITSLeeds / UK2GTFS

Convert UK transport data (TransXchange / ATOC CIF) to GTFS format in R
https://itsleeds.github.io/UK2GTFS/
GNU General Public License v3.0
37 stars 13 forks source link

Shapes data #41

Open danieljuschus opened 2 years ago

danieljuschus commented 2 years ago

I noticed that the function atoc2gtfs generates an error ("Shapes are not yet supported") if shapes = True. Has this just not been implemented yet, or does the data from atoc.org not include shape information at all? I tried to take a quick look at their manual, but I couldnt't figure it out.

mem48 commented 2 years ago

The feature hasn't been properly implemented. The ATOC data does not include the necessary information so I'd started implementing my own solution but it was very time consuming.

There is some old code https://github.com/ITSLeeds/UK2GTFS/blob/2a376bc88e4dfa3f1f0f331139c1685dfff0dbe4/R/atoc_shapes.R if your intrested

danieljuschus commented 2 years ago

Alright! I've tried to use this: https://github.com/ad-freiburg/pfaedle but it didn't work with the output from UK2GTFS. The problem is that there are some stop_id values in stop_times.txt which don't appear in stops.txt. Is that a know problem?

mem48 commented 2 years ago

Thanks for this, I have a look and see if I can get it working with UK2GTFS

stupidpupil commented 2 years ago

I'm not doing anything clever and it's very messily put together, but I'm now using pfaedle in my Wales-centric processing.

(I note that I do filter out some inconsistencies as part of chopping outputs down to a particular space and time, and then I put the GTFS files through gtfstidy before pfaedle.)

mem48 commented 1 year ago

@stupidpupil & @danieljuschus FYI I've now added support for this as a separate function https://itsleeds.github.io/UK2GTFS/reference/ATOC_shapes.html Needs mor testing before rolling into the main function