ITSLeeds / UK2GTFS

Convert UK transport data (TransXchange / ATOC CIF) to GTFS format in R
https://itsleeds.github.io/UK2GTFS/
GNU General Public License v3.0
37 stars 13 forks source link

Human names #43

Closed nighthawk closed 2 years ago

nighthawk commented 2 years ago

Changes:

mem48 commented 2 years ago

Thanks for the PR, I can see why some of these are useful changes but why remove the route_short_name the IDs are good for debugging.

nighthawk commented 2 years ago

Thanks for the PR, I can see why some of these are useful changes but why remove the route_short_name the IDs are good for debugging.

The IDs are still in the route_id. I removed them from the short name as they aren't the actual short names of the routes as as you end up with different names for the same route when updating the data and doing a new conversion to GTFS.

mem48 commented 2 years ago

Ok I see the logic, but some tests reject GTFS files that are missing short names, so it would be good to put something in their place.