Closed nighthawk closed 2 years ago
Thanks for the PR, I can see why some of these are useful changes but why remove the route_short_name
the IDs are good for debugging.
Thanks for the PR, I can see why some of these are useful changes but why remove the
route_short_name
the IDs are good for debugging.
The IDs are still in the route_id
. I removed them from the short name as they aren't the actual short names of the routes as as you end up with different names for the same route when updating the data and doing a new conversion to GTFS.
Ok I see the logic, but some tests reject GTFS files that are missing short names, so it would be good to put something in their place.
Changes:
route_short_name
, make it empty insteadroute_long_name
route_long_name
; consumers can add that from the route type, if needed