ITSLeeds / UK2GTFS

Convert UK transport data (TransXchange / ATOC CIF) to GTFS format in R
https://itsleeds.github.io/UK2GTFS/
GNU General Public License v3.0
37 stars 13 forks source link

Performance + Verbosity of validation + thoroughness of fixing #54

Closed oweno-tfwm closed 1 year ago

oweno-tfwm commented 1 year ago

performance: change call from bind to use data.table verbosity: write to console details of the data causing problems during check cleaning: add option to remove 'non-public' services (null route_type) so that the resulting data can load into OTP (and projects like OTP4GB without error) fixing: be more thorough at maintaining referential integrity of output data e.g. ensure that if an agency is missing, data for that agency is removed.

See individual commits for more detail

codecov-commenter commented 1 year ago

Codecov Report

Merging #54 (087b526) into master (f9bcafb) will decrease coverage by 0.44%. The diff coverage is 11.36%.

:exclamation: Current head 087b526 differs from pull request most recent head 954954c. Consider uploading reports for the commit 954954c to get more accurate results

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
- Coverage   58.52%   58.08%   -0.44%     
==========================================
  Files          32       32              
  Lines        3882     3913      +31     
==========================================
+ Hits         2272     2273       +1     
- Misses       1610     1640      +30     
Files Changed Coverage Δ
R/gtfs_validate.R 50.00% <0.00%> (-6.80%) :arrow_down:
R/gtfs_cleaning.R 8.16% <7.14%> (-0.18%) :arrow_down:
R/atoc_export.R 88.47% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

mem48 commented 1 year ago

Looks good but I don't understand the removeNonPublic in gtfs_clean can you explain?

mem48 commented 1 year ago

Also, I've made some other fixes in main which are causing the tests to fail. Can you pull my fixes into your branch so that we can retest your PR?