Closed oweno-tfwm closed 1 year ago
Merging #54 (087b526) into master (f9bcafb) will decrease coverage by
0.44%
. The diff coverage is11.36%
.:exclamation: Current head 087b526 differs from pull request most recent head 954954c. Consider uploading reports for the commit 954954c to get more accurate results
@@ Coverage Diff @@
## master #54 +/- ##
==========================================
- Coverage 58.52% 58.08% -0.44%
==========================================
Files 32 32
Lines 3882 3913 +31
==========================================
+ Hits 2272 2273 +1
- Misses 1610 1640 +30
Files Changed | Coverage Δ | |
---|---|---|
R/gtfs_validate.R | 50.00% <0.00%> (-6.80%) |
:arrow_down: |
R/gtfs_cleaning.R | 8.16% <7.14%> (-0.18%) |
:arrow_down: |
R/atoc_export.R | 88.47% <100.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Looks good but I don't understand the removeNonPublic
in gtfs_clean
can you explain?
Also, I've made some other fixes in main
which are causing the tests to fail. Can you pull my fixes into your branch so that we can retest your PR?
See individual commits for more detail