search

ITSLeeds / UK2GTFS

Convert UK transport data (TransXchange / ATOC CIF) to GTFS format in R
https://itsleeds.github.io/UK2GTFS/
GNU General Public License v3.0
37 stars 13 forks source link

explicitly namespace dopar transxchange try calls #60

Closed mpadge closed 10 months ago

mpadge commented 10 months ago

@mem48 Thanks for this awesome package! This PR fixes a bug that will affect some systems (including mine, on which the main functions do not work). The workers spawned by dopar calls won't necessarily have the package loaded, dependent on complex interactions between OS and multi-threading libraries, so it's always important to explicitly namespace functions called. Your calls here are to internal functions, which require ::: notation, but as I guess this package is not intended to get to CRAN (right?), that should be acceptable. Happy to discuss alternatives if you prefer.

mem48 commented 10 months ago

Thanks, I've merged. I would like to get this on CRAN one day but there is a lot of cleaning to do including fixing up the parallel processing.