Closed Robinlovelace closed 1 year ago
I tried to get started with this one. Just to make sure: I know you are stplanr
's maintainer, but I have seen, though, that line2route()
still exists in stplanr
documentation and is still available in the latest cran version (0.8).
Hi @ccamara, good point :facepalm: assumed that when I created the route()
function I removed the older line2route()
function... Seems it's still there and working, as per the reprex below. What do you think we should do, leave it as is? Advantage of route()
with the cyclestreets journey()
function is that it returns data at the segment level, including the 'busyness' of each segment rather than aggregates over the whole route:
library(stplanr)
l <- flowlines[2:5, ]
r <- line2route(l)
mapview::mapview(r)
Created on 2020-11-28 by the reprex package (v0.3.0)
FYI, here is an example of where I replaced one of the existing instances of line2route()
: https://github.com/ITSLeeds/pct/commit/54863cd1654c5876480dfc70b8783dddf7f8445f#diff-8afb26e5ed777617d6c1bba656e73e239aa283d9018346deb66db41cb430e871L267
Following #76, I noticed a documentation issue:
Problem: the function no longer exists! It has been replaced by the function
route()
and should be adapted as follows:That may create additional issues in terms of reproducibility but for now switching those is worth doing.