Enable cross build against scala 2.12 and 2.13

ITV / scala-pact

A Scala implementation of CDC using the Pact standard

Other

108 stars 54 forks source link

Closed aumann closed 4 years ago

aumann commented 4 years ago

Fixes #136

Adds htt4s-0-21 (http4s-0-20 only built upto 2.13_M5)

aumann commented 4 years ago

Sorry for the silence, will tackle the remaining issues today.

aumann commented 4 years ago

I addressed the comments w.r.t. the builders / build.sbt

Concerning the WartRemover.Any stuff:

I tried fixing the http4s response warnings
However, afterwards there were warnings everywhere in com.itv.scalapact.ScalaPactVerify
Maybe this is related to https://github.com/wartremover/wartremover/issues/454

davesmith00000 commented 4 years ago

Hi @aumann - sorry - our turn to be slow! Just wanted to say that this hasn't been forgotten, I'll try and take a look in the next couple of days.

vilunov commented 4 years ago

@dantb @davesmith00000 Hi! Is there any progress on reviewing this PR?

orium commented 4 years ago

Thanks @aumann. I went ahead and solved the conflicts with master and did some minor tweaking.