Hi @jbwheatley, superficially looks fine - good idea testing the client.
Two comments:
As mentioned we tend not to pull in milestone versions because it causes problems for our users. Is this blocking anything? Can we afford to wait?
@dantb's build work is saying there are problems. Have you run scripts/local-build-test.sh having changed the dependencies to your new version and checked it's all ok?
Thanks,
Dave
@davesmith00000 yeah it can wait. It wasn't pressing but we have a service being written using http4s 0.21 milestones, and it will need pact tests at some point.
Hi @jbwheatley, superficially looks fine - good idea testing the client. Two comments:
scripts/local-build-test.sh
having changed the dependencies to your new version and checked it's all ok? Thanks, Dave