search

ITV / scala-pact

A Scala implementation of CDC using the Pact standard
Other
108 stars 54 forks source link

add module for http4s 0.21.0-M6 #152

Closed jbwheatley closed 4 years ago

davesmith00000 commented 4 years ago

Hi @jbwheatley, superficially looks fine - good idea testing the client. Two comments:

  1. As mentioned we tend not to pull in milestone versions because it causes problems for our users. Is this blocking anything? Can we afford to wait?
  2. @dantb's build work is saying there are problems. Have you run scripts/local-build-test.sh having changed the dependencies to your new version and checked it's all ok? Thanks, Dave
jbwheatley commented 4 years ago

@davesmith00000 yeah it can wait. It wasn't pressing but we have a service being written using http4s 0.21 milestones, and it will need pact tests at some point.

channingwalton commented 4 years ago

looks like 0.21 RC will be released very soon

channingwalton commented 4 years ago

👍