search

ITV / scala-pact

A Scala implementation of CDC using the Pact standard
Other
108 stars 54 forks source link

ScalaPactHttpClient.doRequestIO should have configurable request timeout #156

Closed jbwheatley closed 4 years ago

jbwheatley commented 4 years ago

This hard-coded value should be made configurable: https://github.com/ITV/scala-pact/blob/21c554f253c2c2b1ad12277597552ef69a78902d/scalapact-http4s-0-21/src/main/scala/com/itv/scalapact/http4s21/impl/ScalaPactHttpClient.scala#L53

When using .runVerificationAgainst it eventually uses this: https://github.com/ITV/scala-pact/blob/f2fb3d68bdf169c05e5b3a6c10ae04489baff852/scalapact-core/src/main/scala/com/itv/scalapactcore/verifier/Verifier.scala#L232

Which is calling the above in the default implementation