search

ITV / scala-pact

A Scala implementation of CDC using the Pact standard
Other
108 stars 54 forks source link

Fix results publisher request format #163

Closed mturlo closed 3 years ago

mturlo commented 4 years ago

On broker version 2.58.0 (only tested against this version), the success field is expected to be a proper JSON boolean instead of a string. Posting a "true" or "false" JSON string in the request body results in HTTP 400 broker response:


{
  "errors": {
    "success": [
      "must be boolean"
    ]
  }
}
ryantaplin commented 3 years ago

Any idea on when this will be merged? This is a blocking issue for us.

jbwheatley commented 3 years ago

Pact_broker doc confirming it expects a boolean rather than string: https://github.com/pact-foundation/pact_broker/blob/master/lib/pact_broker/doc/views/pact/publish-verification-results.markdown

dantb commented 3 years ago

That has been released at version 2.3.18 @ryantaplin