search

ITV / scala-pact

A Scala implementation of CDC using the Pact standard
Other
108 stars 54 forks source link

Pending pacts #188

Closed jbwheatley closed 3 years ago

jbwheatley commented 3 years ago

160

jbwheatley commented 3 years ago

Hey @bethesque, thanks for taking a look! Glad to have an experienced pair of eyes on it.

the overall verification task should now only fail if a non-pending pact fails verification

Yep, this is what has been implemented. Also failures of pending pacts are still reported to the pact broker in the same way as non-pending failures have been (if publishing results is enabled).

PendingStateNotice seems to be putting business logic into the code that I don't think it should know about.

You're totally right, this naming is too specific. I'll change it 😄