search

ITV / scala-pact

A Scala implementation of CDC using the Pact standard
Other
108 stars 54 forks source link

Pact verification does not publish provider tags #207

Closed solarmosaic-kflorence closed 3 years ago

solarmosaic-kflorence commented 3 years ago

I am using pactBrokerWithVersionSelectors with publishResultsEnabled. I expected this to publish the results along with the provided providerVersionTags, but it does not. This seems to deviate from the consumer pact publishing behavior, which publishes the pacts along with the tags. This means that currently for my CI builds, the consumer pacts are correctly tagged with the branch, but the provider verification results are not.

https://docs.pact.io/pact_broker/tags/#when-publishing-verification-results

jbwheatley commented 3 years ago

Good spot. Nice to see someone is trying to use scala-pact for some of the less vanilla pact features than we have! This feature is missing and needs to be added.

solarmosaic-kflorence commented 3 years ago

@jbwheatley I opened a work in progress PR as a starting point. Feel free to take that over if you have time as it will take me awhile to figure out how to test it.

jbwheatley commented 3 years ago

@solarmosaic-kflorence I've got some time, I'll have a look at you branch