search

ITV / scala-pact

A Scala implementation of CDC using the Pact standard
Other
107 stars 53 forks source link

Fixes #207: tagging provider verifications #208

Closed solarmosaic-kflorence closed 3 years ago

solarmosaic-kflorence commented 3 years ago

See #207 -- adds tags to the provider version prior to verifying results. The pb:provider link should be defined here, according to https://github.com/pact-foundation/pact_broker/blob/master/spec/lib/pact_broker/api/decorators/pact_decorator_spec.rb#L81

solarmosaic-kflorence commented 3 years ago

Hm, it's failing on PrePactsForVerificationVerifier -- seems to be "consumer verification". I'm not sure what the context for this is 😬

jbwheatley commented 3 years ago

Hm, it's failing on PrePactsForVerificationVerifier -- seems to be "consumer verification". I'm not sure what the context for this is 😬

The build is failing because publishVerificationResults is also used PrePactsForVerificationVerifier.scala. The new argument you added needs to be included there too. Should be Nil in that case.

solarmosaic-kflorence commented 3 years ago

The build is failing because publishVerificationResults is also used PrePactsForVerificationVerifier.scala. The new argument you added needs to be included there too. Should be Nil in that case.

I saw that, but wasn't sure if Nil was an appropriate default. Makes sense though.

jbwheatley commented 3 years ago

Looks good. I'll have another quick glance in the morning with fresh eyes, then will get this merged

solarmosaic-kflorence commented 3 years ago

@jbwheatley what is the release process like for this project? Are we able to test this change against a real broker/integration somewhere before it gets released?

jbwheatley commented 3 years ago

We have some integration tests against the pact-foundation's test broker. I'm going to fiddle with those and add something that ensures tags are being put along side the verification results. I'll then do a release shortly after.

solarmosaic-kflorence commented 3 years ago

Great, thanks @jbwheatley!