search

ITV / scala-pact

A Scala implementation of CDC using the Pact standard
Other
108 stars 54 forks source link

Added a http4s0.23 version to help with cats effect 3 upgrades. #220

Closed lancewalton closed 3 years ago

jbwheatley commented 3 years ago

need to run sbt scalafmtAll for the build to pass

jbwheatley commented 3 years ago

how desperately do you need? I would rather not do a full release with an RC version

lancewalton commented 3 years ago

I don't absolutely need it, but I've been working on the upgrade on one of oasvc services for a week & this is the last piece I need. The upgrade could just stay on a branch until we have a full release of that http4s stream. Not sure how long that'll be though. But on the other hand, not much is going to need to be done to that service either, so the branch is unlikely to go stale.

lancewalton commented 3 years ago

It looks like the only reason https23 is at RC1 still is because they're waiting for circe 0.14, which is already released. Hopefully they'll do a full release soon.... let's wait & see.

jbwheatley commented 3 years ago

yep, lets give the http4s guys a little bit to catch up with our lightning fast development 😉

lancewalton commented 3 years ago

I've converted this to draft. It's not quite right anyway.

dantb commented 3 years ago

I've run local-build-test.sh and it's looking good. How do you feel about me sticking this in maven under 3.3.2-RC1 @jbwheatley ? I think I can still do it, although it's been a while. Only a new module so no breaking changes AFAICT

jbwheatley commented 3 years ago

@dantb go ahead!