ITachiLab / hotkey-detective

A small program for investigating stolen key combinations under Windows 7 and later.
GNU General Public License v3.0
403 stars 17 forks source link

Not working at all on Windows 10.0.21376 Build 21376 #8

Open megalofauna opened 3 years ago

megalofauna commented 3 years ago

Running dev build 👉 Windows 10.0.21376 Build 21376

Hotkey Detective (running as admin) fails to load GUI (v1) or console (v0.1). Just spins and locks up explorer.exe.

ITachiLab commented 3 years ago

Hi, thanks for reporting this, and sorry for waiting so long for the answer. I can't precisely say what's wrong as I tested Hotkey Detective on multiple machines running Windows 10 and everything worked fine. For the time being, the only thing that comes to my mind could be an antivirus blocking the DLL injection routine.

Unshackle8078 commented 3 years ago

Mine loads but will not register any key presses at all.

ITachiLab commented 3 years ago

Did you run it with administrator privileges? I'm currently in the middle of #9, so the users don't forget to do so.

Unshackle8078 commented 3 years ago

Yes I did do that.

iG8R commented 1 year ago

Same here. I ran it with administrative privileges, the main window appeared and that's it - no reaction to any keyboard shortcuts, only an empty grid. PS. Microsoft Windows [Version 10.0.19043.1415]

ITachiLab commented 1 year ago

@iG8R Thanks for the feedback, I will give it a closer look then. Just for clarity - did you try both x86 and x64 versions? Also, did you try pressing a shortcut that's actually used by some other application? Hotkey Detective doesn't react to every key combination, it only reacts to shortcut which would go to the application which registered it. In other words, if the key combination you are pressing is not assigned to any application, Hotkey Detective will not show it.

iG8R commented 1 year ago

@ITachiLab Thanks to remind me regarding to check all versions. x86 works fine but x64 - doesn't. But my OS is 64-bit. Could you make Hotkey Detective display all pressed combinations, not only registered in applications, but show "None" in the field related to the "Process path" column?

ITachiLab commented 1 year ago

OS version doesn't matter in this case, what matters is how the application (the hotkey stealer) was compiled. If the application was compiled as x86, it will run on x64, but it can't be injected x64 DLLs. Hotkey Detective works by means of injecting a DLL into processes to hook on shortcut events. That's why on x64 systems you have to try both x86 and x64 because you never know what architecture the application uses.

Could you make Hotkey Detective display all pressed combinations, not only registered in applications, but show "None" in the field related to the "Process path" column?

For this to work nicely, Hotkey Detective would need to register all possible key combinations. Besides, the shortcut might be assigned to something, but a different architecture must be tried, so writing just "None" could be misleading.

What I can do is to write a simple wrapper for Hotkey Detective which displays a window with two buttons: "x64" and "x32", and with a message that says: "For the best results, try running both versions". Or something similar.

iG8R commented 1 year ago

Thank you for the explanation. Is it possible to make Hotkey Detective show any notification and don't play dead when an ownerless key combination is pressed?

ITachiLab commented 1 year ago

That could be tricky to implement, but I can give it a chance. For sure I shouldn't just register all possible shortcut combinations with Hotkey Detective because that would be like 500 or even more of them.

I will create a new feature issue for this to track the progress. Any further comments regarding your suggestion should be added to the new issue.

iG8R commented 1 year ago

Thank you.