Closed orialb closed 4 years ago
hmm, are the tests for this package running as part of the ITensors.jl test suite?
Looks good, thanks! We just haven't set up CI here yet, for now we are being lazy and testing NDTensors through ITensor functionality (since the tests would often mirror each other anyway, and NDTensors is mostly being developed for internal use in ITensors.jl at the moment).
Though it is great that you added tests, and we should set up CI here even though the coverage is pretty bad right now.
Maybe you can setup CI such that PRs to NDTensors run the ITensors test suite?
Not a bad idea, we could look into it.
The NDTensors part for https://github.com/ITensor/ITensors.jl/issues/394 .