Closed mtfishman closed 4 years ago
Yeah it's deceptively simple. It looks like it is working. My main concern was whether or not it uses the proper branch of NDTensors when the ITensors.jl tests are run (i.e. the branch of the pull request getting tested, instead of the latest registered version). I believe it is working correctly here, I see the following line:
[23ae76d9] NDTensors v0.1.11 [`~/work/NDTensors.jl/NDTensors.jl`]
in the Github Actions logs in the part where the ITensors tests are being run. We could also make a PR where we change something in NDTensors that breaks something in ITensors to double check.
Great idea about the intentionally-breaking PR. I can do that after you merge this PR!
Wow, the Pkg library really makes this simple to do. That’s great. I was thinking it was going to require many more steps.