Make NDTensors compatible with Julia v1.3

ITensor / NDTensors.jl

A Julia package for n-dimensional sparse tensors.

Apache License 2.0

27 stars 7 forks source link

Make NDTensors compatible with Julia v1.3 #38

Closed mtfishman closed 4 years ago

mtfishman commented 4 years ago

This uses Compat.jl to make NDTensors backwards compatible with Julia v1.3. There are a few small features we are using that were introduced in Julia v1.4, and Compat automatically defines them if someone is using Julia v1.3 and NDTensors.

Unfortunately we can't easily become compatible with older versions, mostly because the keyword argument alg in LinearAlgebra's svd function (for choosing the LAPACK svd algorithm) was introduced in Julia v1.3.

mtfishman commented 4 years ago

This is failing in a catch-22, in order for Julia v1.3 tests to run, it is checking the compatibility requirements for ITensors, but ITensors requires Julia v1.4, which can't be changed until this is merged. I'll just merge this, since it shouldn't break anything for people using Julia v1.4.