search

ITrust / angular-xmlrpc

An AngularJS service which provides XML-RPC communication methods.
Apache License 2.0
11 stars 13 forks source link

Fix issue with polyfilled array prototype functions #4

Closed denyskoch closed 8 years ago

denyskoch commented 8 years ago
  1. typeof children == 'array' is always false, since there is no type array (see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/typeof)
  2. Some sites using ES polyfills like Array.remove() and in some use cases children is an array, but it is passed to appendChild, where for-in look also loops over polyfilled props -> error
jchakra commented 8 years ago

Denyskoch, Thanks for your attention about this project :) The ugly and non-working typeof has been fixed by recent commits. A new tagged version is available : 1.1.0.