Feature/upload photo backend

[IrynaRobulets]

• [x]  File: DevelopGitHub/GitHubExtension/GitHubExtension.Security.WebApi/Controllers/AccountController.cs:L31-49
• <img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'> You really need instance type not interface?
• [x]  File: DevelopGitHub/GitHubExtension/GitHubExtension.Security.WebApi/Controllers/AccountController.cs:L63-70
• <img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'> Hmm...Explain why you are is not awaiting your avatar url?
• <img border=0 src='https://avatars.githubusercontent.com/u/17322068?v=3' height=16 width=16'> I'm waiting it now.
• [x]  File: DevelopGitHub/GitHubExtension/GitHubExtention.Preferences.WebApi/AvatarOperations.cs:L1-32
• <img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'> Strange. Why you prevent using async/await functionality?
• <img border=0 src='https://avatars.githubusercontent.com/u/17322068?v=3' height=16 width=16'> I have changed it to async
• [x]  File: DevelopGitHub/GitHubExtension/GitHubExtention.Preferences.WebApi/Azure/AzureBlobStorageMultipartProvider .cs:L1-61
• <img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'> Please hide all details of implementation by interface. SOLID...Class should be acceptable for extension not for MODIFICATION! The second part you should not rely on implementation of MultipartFileStreamProvider it can be changed...
• <img border=0 src='https://avatars.githubusercontent.com/u/17322068?v=3' height=16 width=16'> If I use interface instead of AzureBlobStorageMultipartProvider. I can't use ReadAsMultipartAsync(_multipartStreamProvider) becuase this method requires paramater refernces to abstract class MultipartStreamProvider. As a result I need to make my own conten reading provider. Am I understand you?
• <img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'> Interesting case. But why you did't accept parameters into action body? Instear using Request property of ApiController? As I understand Web Api allows to have mixed parameters inside action signature.
• [x]  File: DevelopGitHub/GitHubExtension/GitHubExtention.Preferences.WebApi/Azure/AzureBlobStorageMultipartProvider .cs:L1-61
• <img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'> Nice injection...Why you are not using the same approach with MultipartProvider?
• <img border=0 src='https://avatars.githubusercontent.com/u/17322068?v=3' height=16 width=16'> Do you mean MultipartFileStreamProvider? Why I need to inject it, there is no place where I create an instance. It's only inheritance from this class.
• <img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'> Yep, need to think how to better use this Provider.
• [x]  File: DevelopGitHub/GitHubExtension/GitHubExtention.Preferences.WebApi/Controllers/UserPreferencesController.cs:L1-77
• <img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'> You really need expose access to all persictence layer?
• <img border=0 src='https://avatars.githubusercontent.com/u/17322068?v=3' height=16 width=16'> Nope, I've changed it
• [x]  File: DevelopGitHub/GitHubExtension/GitHubExtention.Preferences.WebApi/Controllers/UserPreferencesController.cs:L1-77
• <img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'> Please don't mix persistence layer with Azure complexity...It should be separarted btw DbContext also support async operations.
• [x]  File: DevelopGitHub/GitHubExtension/GitHubExtention.Preferences.WebApi/Extensions/HttpResponseExtensions.cs:L1-19
• <img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'> Can you explain why this method is not extension method with a single responsibility?
• <img border=0 src='https://avatars.githubusercontent.com/u/17322068?v=3' height=16 width=16'> Now it's with single responsibility.
• [x]  File: DevelopGitHub/GitHubExtension/GitHubExtention.Preferences.WebApi/Package/PreferencesPackage.cs:L1-43
• <img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'> You really need this registration?
• <img border=0 src='https://avatars.githubusercontent.com/u/17322068?v=3' height=16 width=16'> I'm not sure exectly, I guess if user not null he has permissions to update photo. I check permissions because they can be changed in the azure out of code. So, if supose that permissions won't be changed in Azure this checking have no sence. Do I need get it away?
• [x]  File: DevelopGitHub/GitHubExtension/GitHubExtention.Preferences.WebApi/Azure/AzureBlobStorageMultipartProvider .cs:L1-61
• <img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'> You can return file location from method UpdateBlob. It's covered by case when after uploading file you will get path to it location.
• [x]  File: DevelopGitHub/GitHubExtension/GitHubExtention.Preferences.WebApi/AvatarOperations.cs:L1-35
• <img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'> Method with a Get prefix but inside the body it;s call UpdateBlob? Can you clarify this....
• <img border=0 src='https://avatars.githubusercontent.com/u/17322068?v=3' height=16 width=16'> This method calls when user firstly register in our system and only way to get image url is to send request to GitHub get image, save this image to blobStorage and finally get the image url. Maybe it better to make two method one for getting image file and second for saving this image to blobStorage.
• [x]  File: DevelopGitHub/GitHubExtension/GitHubExtention.Preferences.WebApi/Queries/PreferencesQuery.cs:L1-36
• <img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'> I see a small smell...You are exposing Users property and also declare GetUser method in interface? Do not many methods inside interface? Where our flexibility related to IOrderedQueryable?
• <img border=0 src='https://avatars.githubusercontent.com/u/17322068?v=3' height=16 width=16'> Changed it.
• [ ]  File: DevelopGitHub/GitHubExtension/GitHubExtention.Preferences.WebApi/Queries/PreferencesQuery.cs:L1-36
• <img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'> May be it's better to pass User entity with updated state? Because now I don't see any reson to pass this additional parameter as URL.
• [x]  File: DevelopGitHub/GitHubExtension/GitHubExtention.Preferences.WebApi/Models/FileModel.cs:L1-29
• <img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'> We need this alone constructor?
• <img border=0 src='https://avatars.githubusercontent.com/u/17322068?v=3' height=16 width=16'> Now, no
• [x]  File: DevelopGitHub/GitHubExtension/GitHubExtention.Preferences.WebApi/Formatters/FileMediaFormatter.cs:L1-86
• <img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'> Move to extesion methods.
• [x]  File: DevelopGitHub/GitHubExtension/GitHubExtention.Preferences.WebApi/Formatters/FileMediaFormatter.cs:L1-86
• <img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'> Can this method simplified?
• <img border=0 src='https://avatars.githubusercontent.com/u/17322068?v=3' height=16 width=16'> In stead it I use built-in. And this one I deleted.
• [x]  File: DevelopGitHub/GitHubExtension/GitHubExtention.Preferences.WebApi/AvatarOperations.cs:L1-35
• <img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'> May be you should first check is fomat valid and the setting up all properties?
• <img border=0 src='https://avatars.githubusercontent.com/u/17322068?v=3' height=16 width=16'> Yeap, it's more logical
• [x]  File: DevelopGitHub/GitHubExtension/GitHubExtention.Preferences.WebApi/Controllers/UserPreferencesController.cs:L1-81
• <img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'> Please rename to something like IsUrlValidbecause I don't see that we work with actual files. Only urls. Correct?
• <img border=0 src='https://avatars.githubusercontent.com/u/17322068?v=3' height=16 width=16'> 1. Done
• I guess that method name is not the best. The idea is to check if the avatar url have changed than we need to update this field in database and delete unnecessary file from blobstorage. If url the same, there is no point to update url in database. Maybe the method name like IsUrlSimilar will be more clear.
• [x]  File: DevelopGitHub/GitHubExtension/GitHubExtention.Preferences.WebApi/Controllers/UserPreferencesController.cs:L1-81
• <img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'> Btw it ca be moved to UserExtension method to chechking url validity.
• <img border=0 src='https://avatars.githubusercontent.com/u/17322068?v=3' height=16 width=16'> I deleted this checking as it is unnecessary part. On Github always you have avatar and our system doesn't update image if newUrl is null.
• [ ]  File: DevelopGitHub/GitHubExtension/GitHubExtention.Preferences.WebApi/Extensions/HttpResponseExtensions.cs:L1-20
• <img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'> I like such small and concrete extension methods.
• <img border=0 src='https://avatars.githubusercontent.com/u/17322068?v=3' height=16 width=16'> I like too^^)
• [x]  File: DevelopGitHub/GitHubExtension/GitHubExtention.Preferences.WebApi/Controllers/UserPreferencesController.cs:L1-81
• <img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'> So I suggest all magic happens inside formatter and here you already have filled all necessesary fields?
• <img border=0 src='https://avatars.githubusercontent.com/u/17322068?v=3' height=16 width=16'> Yes
• [ ]  File: DevelopGitHub/GitHubExtension/GitHubExtension.Security.WebApi/Controllers/AccountController.cs:L64-72
• <img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'> What happens if registration failed? Image avatar will be saved?
• [ ]  File: DevelopGitHub/GitHubExtension/GitHubExtension.Security.WebApi/Extensions/Query/GitHubQueryExtesions.cs:L1-24
• <img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'> Exposing HttpClient is't no a good idea.
• [ ]  File: DevelopGitHub/GitHubExtension/GitHubExtension.Security.WebApi/Queries/Implementations/GitHubQuery.cs:L23-34
• <img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'> Should be removed from interface.