Feature/external activity tests - Githubissues

ITsvetkoFF / Kv-013

7 stars 1 forks source link

Feature/external activity tests #157

Closed senioroman4uk closed 8 years ago

senioroman4uk commented 8 years ago

Add tests for external activity routes, controller and extensions

[ ] File: DevelopGitHub/GitHubExtension/GitHubExtension.Activity.External.Tests/Extensions/IdentityExtensions.cs:L1-18
<img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'> Is it correct class name IdentityExtensions?
<img border=0 src='https://avatars.githubusercontent.com/u/10225385?v=3' height=16 width=16'> It is an extension for mocking identity in other our test projects it is called this way
<img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'> And it's extend ApiController?
<img border=0 src='https://avatars.githubusercontent.com/u/10225385?v=3' height=16 width=16'> Yes
[ ] File: DevelopGitHub/GitHubExtension/GitHubExtension.Activity.External.Tests/TestsForRoutes/Extensions/ExternalActivityRouteTestExtensions.cs:L1-13
<img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'> Am I right understand that I can apply this extension method to any string?
<img border=0 src='https://avatars.githubusercontent.com/u/10225385?v=3' height=16 width=16'> Yes, it is. It looked weird to me, but in our other tests it is made this way
<img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'> Hmm...Then it's my fault that I passed such extension methods. Can you refactor this?
[ ] File: DevelopGitHub/GitHubExtension/GitHubExtension.Activity.External.Tests/TestsForControllers/ActivityControllerGetActivityTests.cs:L1-155
<img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'> As I remember we already agreed class name for our tests. It should be controller name + Tests. Can you explain what means GetActivity postfix?
<img border=0 src='https://avatars.githubusercontent.com/u/10225385?v=3' height=16 width=16'> Understood I'll rename it as it has to be one test per controller. Understood I looked on our previous tests, my bad
[x] File: DevelopGitHub/GitHubExtension/GitHubExtension.Activity.External.Tests/TestsForExtensions/GetPagesAmountExtensionTests.cs:L1-170
<img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'> May be it's better to use attribute InlineData()?
[ ] File: DevelopGitHub/GitHubExtension/GitHubExtension.Activity.External.Tests/TestsForExtensions/GetPagesAmountExtensionTests.cs:L1-170
<img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'> What is expected value?
<img border=0 src='https://avatars.githubusercontent.com/u/10225385?v=3' height=16 width=16'> It is expected to have a value, not to be null. I wrote separate test that checks exact value lower.
[x] File: DevelopGitHub/GitHubExtension/GitHubExtension.Activity.External.Tests/TestsForExtensions/GetPagesAmountExtensionTests.cs:L1-170
<img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'> You are mocking IGitHubEventsQuery and then call GetNumberOfPages method? Are you sure?
<img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'> I see then it's ok.