rhorenov
commented
1 year ago Hi guys,
I'm very new to NeTEx / EPIP, so be gentle.
The problem
I was using you validation tool - good work BTW, to check validity of experimentally generated timetables and I assume I get the same issues reported as in the OP. XML file attached bellow.
The issues reported are in the same vein as this one:
{
"message": "In violation of key-ref constraint, missing key reference \"TypeOfFrame_AnyKeyRef\" (@ref=\"epip:EU_PI_LINE_OFFER\")",
"line": 7,
"type": "consistency"
},It refers to this part of the XML:
I believe the issues are being reported incorrectly.
Expected behavior
Here is a snapshot from the document: "Public transport - Network and Timetable Exchange (NeTEx)— Part 4: Passenger Information European Profile", chapter 9.7 "Referential integrity".
If I understand it correctly, external references, marked with attribute versionRef shall be ignored by the checker.
I believe this issue (#67) is actually an error in the validation tool and not just an enhancement.
I would very much appreciate if it could be fixed. More so that I’ve noticed that there has been some work done recently in the key ref constraint evaluation JS rule.
If I can be of any help, let me know.
Regards, Roman
Support data
Sample file: netex_epip_rhorenov_02.zip
DATA4PTTools version: 57aa7b7, tag:1.0.4, "Merge pull request #87 from ITxPT/fix/keyref", locally built docker image OS: Microsoft Windows [Version 10.0.19045.3086]
Command:
docker run --rm -it -v C:\Work\TTR\2023-NeTEx\DATA4PTTools\mytestdata:/usr/local/greenlight/mytestdata netex validate --output json --schema epip@1.1.1 --input mytestdataResult:
[
{
"name": "mytestdata/netex_epip_rhorenov_02.xml",
"valid": false,
"validations": [
{
"name": "everyLineIsReferenced",
"valid": true
},
{
"name": "everyStopPlaceHasAName",
"valid": true
},
{
"name": "everyStopPlaceHasACorrectStopPlaceType",
"valid": true
},
{
"name": "stopPlaceQuayDistanceIsReasonable",
"valid": true
},
{
"name": "frameDefaultsHaveALocaleAndTimeZone",
"valid": true
},
{
"name": "everyScheduledStopPointHasAName",
"valid": true
},
{
"name": "everyStopPointHaveArrivalAndDepartureTime",
"valid": true
},
{
"name": "locationsAreReferencingTheSamePoint",
"valid": true
},
{
"name": "everyStopPlaceIsReferenced",
"valid": true
},
{
"name": "passingTimesIsNotDecreasing",
"valid": true
},
{
"name": "netexUniqueConstraints",
"valid": true
},
{
"name": "netexKeyRefConstraints",
"valid": false,
"error_count": 6,
"errors": [
{
"message": "In violation of key-ref constraint, missing key reference \"TypeOfFrame_AnyKeyRef\" (@ref=\"epip:EU_PI_CALENDAR\")",
"line": 63,
"type": "consistency"
},
{
"message": "In violation of key-ref constraint, missing key reference \"TypeOfFrame_AnyKeyRef\" (@ref=\"epip:EU_PI_STOP\")",
"line": 110,
"type": "consistency"
},
{
"message": "In violation of key-ref constraint, missing key reference \"TypeOfFrame_AnyKeyRef\" (@ref=\"epip:EU_PI_NETWORK\")",
"line": 206,
"type": "consistency"
},
{
"message": "In violation of key-ref constraint, missing key reference \"TypeOfFrame_AnyKeyRef\" (@ref=\"epip:EU_PI_TIMETABLE\")",
"line": 2242,
"type": "consistency"
},
{
"message": "In violation of key-ref constraint, missing key reference \"TypeOfFrame_AnyKeyRef\" (@ref=\"epip:EU_PI_LINE_OFFER\")",
"line": 7,
"type": "consistency"
},
{
"message": "In violation of key-ref constraint, missing key reference \"TypeOfFrame_AnyKeyRef\" (@ref=\"epip:EU_PI_COMMON\")",
"line": 29,
"type": "consistency"
}
]
},
{
"name": "xsd",
"valid": true
}
]
}
]
skinkie
lekotros
I think these errors should be 'corrected', and ideally some external entities should be made present. I also wonder how an ensemble of files could be validated, allowing these external entities to match.