search

IUBLibTech / newton_chymistry

New version of 'The Chymistry of Isaac Newton', using XProc pipelines to generate a website based on TEI XML encodings of Newton's alchemical manuscripts, and Apache Solr as a search engine.
2 stars 0 forks source link

Rendering issue when <note type="biblio"> is used #106

Closed tubesoft closed 3 years ago

tubesoft commented 3 years ago

I found out that when we use <note type="biblio">, it renders a line break. I also found the reason for that. <note> tag was rendered outside popup as well as inside it in HTML.

To suppress the <note> tag outside, I changed line 234 of p5-to-html.xsl into <xsl:template mode="create-content" match="*[not(note[@type='biblio'])]"> from <xsl:template mode="create-content" match="*">

In my local environment, this fix seems to work fine. I am making a note here for the code review later.

tubesoft commented 3 years ago

Since the fix previously explained seemed to create more bugs, I changed line 477 instead.

wehooper commented 3 years ago

Issue has been resolved.