Editorial annotations need to be pop-ups

[aewingate]

From our discussion today, here is the situation with the editorial annotations: In the live site, if you click on the note icon, a small yellow pop-up will appear. (Example taken from Keynes 19 aka ALCH00008, fol. 1r)

But if you go to Carbon and Possum, clicking on the note takes you to the notes section at the very bottom of the page. The note in context Where you go after you click the note icon

The live site, Carbon, and Possum all have this bottom section, and the bottom section should be there, but clicking on the note icon on a given editorial annotation in the manuscript should create a pop-up like in the live site, not automatically take you to the bottom of the page.

[aewingate]

And I forgot to add, the editorial annotations are the ones that are encoded with <ref type="annotation" target="#someXML:ID"/> in the text, and then as <note type="annotation" xml:id="someXML:ID" n="fol. , l. " anchored="true">

In-text In the back matter

[tubesoft]

As we assumed in the meeting, it does not really seem to be a bug, and Con coded like that. The following XSLT code is the part rendering the reference.

https://github.com/IUBLibTech/newton_chymistry/blob/9ec14b20178f8b90bce76ab5b3abb3a8c7d6896e/xslt/p5-to-html.xsl#L608-L615

This code creates the link to the footnote and tooltip. To make sure, we agree that we are adding a pop-up view instead of the link, right?

If so, I am going to modify the code.

[aewingate]

Yes, we want a pop-up, not a link. Thanks!

[tubesoft]

In my local environment, it goes like this so far:

[aewingate]

That seems perfect!

[tubesoft]

In the meeting, we found that the link does not work in a <note> tag. I have to work on it.

[tubesoft]

I managed to fix the problems that we previously discussed: 1) Now we can go back to the annotated location in the text clicking "^" in the footnote; 2) The link to the cross-referenced location is now available in the popup like below:

By the way, @aewingate, besides this issue, it might be needed to modify the TEI code for the multi-column parts.

It is currently rendered as three columns: folio number milestone, left column, and right column. To fix it, we might need to switch certain elements' locations. For detail, see #77, especially my post there. Also, ALCH00091.xml in xubmit is supposed to be already fixed. It should be a good example to compare.

[aewingate]

On 1), great! On 2), is that dark grey pop-up being created by clicking on the "1v" in the lighter pop-up? I like the idea of the secondary pop-up, but I wonder if the team would prefer that you were taken to the actual location on 1v. Also, within the dark grey pop-up, it is printing both options inside of <choice> like <abbr> and <expan>.

On the multi-column issue, I will check ALCH00008 to see how it's encoded. I see what you mean from your post on issue 77.

[aewingate]

@tubesoft, I just looked at the encoding of ALCH00008 and ALCH000091 and their rendering on Carbon. It doesn't look like the issue has been fixed in ALCH00091 because there are still <milestone> inside the <div> with rend="parallel-docs" and it's rendering as three columns like in your screenshot of ALCH00008 above. Maybe we should bring this up with @wehooper tomorrow to see if there's a faster way to deal with this than re-encoding by hand?

[tubesoft]

@aewingate, I should have elaborated it! "1v" is a link that makes you jump to the actual location. The grey popup appears when your mouse pointer is on the link. Probably you can find the same effect in the footnote even on Carbon.

Thank you for pointing out printing all the contents of the elements, which I did not realize. Since I merely copied the feature of footnote, I would probably be nice to create another independent issue.

[tubesoft]

As for double column and milestone issue, @wehooper should have run some script to switch div and milestone, as far as I remember. I think it is worthwhile asking him about it.

[wehooper]

The double-column and milestone placement issues were raised and resolved in November, 2020. They were a separate problem and didn't affect the note-popup's behavior.

[wehooper]

The note popups work as described in the fix in Chrome, Firefox, Edge, and Opera.

[wehooper]

We can close this issue.