IUBLibTech / newton_chymistry

New version of 'The Chymistry of Isaac Newton', using XProc pipelines to generate a website based on TEI XML encodings of Newton's alchemical manuscripts, and Apache Solr as a search engine.
2 stars 0 forks source link

Extra break added after marginal notes #115

Closed aewingate closed 2 years ago

aewingate commented 2 years ago

I'm checking over the rendering on Carbon of ALCH00063-04, and I'm noticing that marginal notes are being rendered with a line break after them, and there shouldn't be. In the TEI, there's no line break after this note: image

But in Carbon, there's a break (and this is on fol. 4.2r): image

On the live site, the note is inline with the text: image

And here's the manuscript for good measure: image

tubesoft commented 2 years ago

I found that the CSS actually creates a line break.

.place-left {
    text-align: left;
    display: block;
}

By setting the element place="left", the element becomes a block element, which creates a line break. If we look at line 345 of ALCH00063-04.xml (latter half of 4.1r), I does not have <note>element, and there is no line breaks.

<g ref="#UNx261e">☞</g> Efficiat igitur ut separetur spiritus ab aqua, ut putrescat &amp; appareat granum <lb/>

I guess we might have to think about several things besides rendering process. I just wondered if we really need <note> for the finger pointing sign since I don't get the meaning of <note> here. If we want to show that sign is on the margin, I just would think we should keep the line break just as we dealt with the text on the right margin and note that it was on the left margin. (I wanted to show an example, but I could not find quickly.)

So far, there is no process for <note> element without type attribute in the xslt code. Do we need to create special rendition process for this case?

aewingate commented 2 years ago

We should ask tomorrow in the general meeting, but I get the impression based on the live site that the team's preference would be for these types of notes not to have line breaks. Semantically, I think they'd still want them to be encoded as <note> since they are extra notes in the margin versus part of the continuous main text (the "authorial notes" in the encoding guide https://wiki.dlib.indiana.edu/pages/viewpage.action?pageId=531699051#EncodingGuide-notes). So my tentative answer is that there should be a special rendition process for this case.

tubesoft commented 2 years ago

Yeah, we should. One thing that I care about is consistency with right margin authorial notes. Of course, the right margin ones always have independent lines because it is technically impossible to make a specific inline element align right. I personally think we should treat left and right margins in the same way. Let us think of the case that the left margin note on a certain page consists of a long line. Since that line should be tagged in the same way by <note place="left"></note>, if it is rendered as an inline element, it will be inserted in a random line, which would not make sense as a text. Therefore, I still think we should leave it as it is.

tubesoft commented 2 years ago

In the meeting, we decided that make both right and left margins inline elements, enclose with daggers, and add comments like "" just as found in the live site.

aewingate commented 2 years ago

@tubesoft Just letting you know that I re-encoded the manicule on 1r of 63.04 as <note place="left">. Have not re-indexed yet, so it won't show up on Carbon yet.

tubesoft commented 2 years ago

So far it goes like this:

image

As for the right column (ALCH00026 - 4r): Local environment:

image

Live page:

image

Manuscript:

image
aewingate commented 2 years ago

I think that looks really great! To my eyes it sets off the marginal note enough from the text.

wehooper commented 2 years ago

This is working correctly now.