IUBLibTech / newton_chymistry

New version of 'The Chymistry of Isaac Newton', using XProc pipelines to generate a website based on TEI XML encodings of Newton's alchemical manuscripts, and Apache Solr as a search engine.
2 stars 0 forks source link

Page language has not been identified (IU Accessibility Mandate) #132

Closed mdalmau closed 6 months ago

mdalmau commented 8 months ago

3,811 occurrences of this issue but the fix is likely in one place. Every HTML root element needs the language attribute: <html lang="en"></html>


IU has a mandate that all web sites published on IU servers must meet WCAG I and II Accessibility requirements. If the requirements are NOT met, sites will be taken down. To learn more about this initiative, visit the Digital Strategy Initiative web site.

mdalmau commented 8 months ago

@tubesoft : At the Newton meeting today, Bill said you would be working on these accessibility issues. I requested SiteImprove access for you. Once you have access, you will login using your @iu credentials. If you want to read more about SIteImprove and accessibility, LOGIN to the KB and start here.

Could you have a look at this issue and confirm it's something you can fix? Once you confirm, we can figure out a testing workflow.

tubesoft commented 7 months ago

SiteImprove seems to indicate that each page of the edited texts needs @lang="en". I am editing p5-to-html.xsl like below:

image
mdalmau commented 7 months ago

@tubesoft yeah I figured this one was easy.

How do you want to handle previous fixes? It’ll be good to crate a pull request for all the rendition issues, test and deploy before you start making the accessibility changes.

tubesoft commented 7 months ago

@mdalmau I just issues a pull request. See #144.

mdalmau commented 6 months ago

Since this issue is now part of https://github.com/IUBLibTech/newton_chymistry/pull/146, I will mark this issue as "done" so I can better see the remaining accessibility issues!