search

IUBLibTech / newton_chymistry

New version of 'The Chymistry of Isaac Newton', using XProc pipelines to generate a website based on TEI XML encodings of Newton's alchemical manuscripts, and Apache Solr as a search engine.
1 stars 0 forks source link

Element IDs are not unique (IU Accessibility Mandate) #140

Open mdalmau opened 5 months ago

mdalmau commented 5 months ago

This may be a more complex developer issue. IDs generated in the HTML are repeated and IDs should be unique. 2,986 occurrences

IU has a mandate that all web sites published on IU servers must meet WCAG I and II Accessibility requirements. If the requirements are NOT met, sites will be taken down. To learn more about this initiative, visit the Digital Strategy Initiative web site.

mdalmau commented 5 months ago

@tubesoft : At the Newton meeting today, Bill said you would be working on these accessibility issues. I requested SiteImprove access for you. Once you have access, you will login using your @iu credentials. If you want to read more about SIteImprove and accessibility, LOGIN to the KB and start here.

Could you have a look at this issue and confirm it's something you can fix? Once you confirm, we can figure out a testing workflow.

PS This one might be more complicated. If it's not clear how to fix this, let me know ASAP and we will work on Plan B.

tubesoft commented 5 months ago

I think this comes from TEI coding. @xml:id is copied to @id in html. I think change the TEI code should work. For example adding the document number to the folio number should work. (From id="thirtythreer-ref-1" to id="ALCH00034-thirtythreer-ref-1")

TEI:

image

Rendered:

image
mdalmau commented 5 months ago

@tubesoft : Is this something that needs to be batch updated in the TEI files?

tubesoft commented 5 months ago

@mdalmau I think so. Just adding the ALCH number to the beginning of the id would work.

mdalmau commented 5 months ago

@tubesoft : I am going to need you to talk me through this issue. I am not sure I fully understand. I'll follow-up over email to schedule a 30 min meeting with you and probably @aewingate too. Alex is pretty familiar with the encoding conventions from updating the encoding guide + all the bibl encoding. I just want to make sure that changing the ID values do not impact something else.

aewingate commented 5 months ago

@tubesoft and @mdalmau, I think that as long as the xml:id and anywhere it is referenced with the "#" change, we're okay. But happy to sit in on whatever meeting. And then I can make changes in the encoding guide as needed