IUBLibTech / newton_chymistry

New version of 'The Chymistry of Isaac Newton', using XProc pipelines to generate a website based on TEI XML encodings of Newton's alchemical manuscripts, and Apache Solr as a search engine.
2 stars 0 forks source link

Rendition issues #99

Closed randalldfloyd closed 3 years ago

tubesoft commented 3 years ago

Sorry for the confusing modification. Maybe because the character for the indentation (such as tab and space) was unintentionally replaced, almost all the code seems to be changed. However, I just modified the very last part of bibliography-to-html.xsl that is: Before:

    <xsl:template match="hi[@rendition='#i']">
        <xsl:element name="span">
            <xsl:attribute name="class" select=" 'rendition-i' "/>
            <xsl:apply-templates/>
        </xsl:element>
    </xsl:template>

and after:

    <xsl:template match="hi">
        <xsl:element name="span">
            <xsl:attribute name="class" select=" replace(@rendition,'#', 'rendition-') "/>
            <xsl:apply-templates/>
        </xsl:element>
    </xsl:template>

Also, we have to be careful when merging that @Conal-Tuohy also modified the same file and committed in the master branch. His commit comment says "render publisher and date in bibliography, to fix issue #88"

tubesoft commented 3 years ago

I think it is ready to merge!