search

IUCompilerCourse / Essentials-of-Compilation

A book about compiling Racket and Python to x86-64 assembly
1.28k stars 140 forks source link

Fixing inconsistencies in Chapters 3 and 4 + workflow to publish pdf #85

Closed proglang closed 2 years ago

proglang commented 2 years ago

sorry for this mixture of commits of different nature. Please check individual comments.

jsiek commented 2 years ago

I don't know how to resolve the conflicts on your branch... could you do that and then merge the PR? Thanks!

proglang commented 2 years ago

IIRC, there are some policy decision that you should take to ensure consistency :-)

For example, should register names be quoted in the X86-ast (as in "rax", etc)? Should it be done as for setcc, where the grammar says 'cc' where cc is a nonterminal (shudder) -> I think not.

On 22.11.21 12:50, Jeremy G. Siek wrote:

I don't know how to resolve the conflicts on your branch... could you do that and then merge the PR? Thanks!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/IUCompilerCourse/Essentials-of-Compilation/pull/85#issuecomment-975441419, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACW5DPTTRYQGE45CACLHOGTUNIVBBANCNFSM5IB4EYVA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

jsiek commented 2 years ago

For the AST grammars, we should probably match how it would be written in code... so yes, include the quotes. For cc, yeah, let's not do quotes around a non-terminal, but instead put quotes on the terminals like "e". How does that sound?