search

IUPAC-InChI / InChI

Main InChI repository
MIT License
28 stars 2 forks source link

aarch64 build reports as 32 bit #10

Closed vfscalfani closed 3 months ago

vfscalfani commented 3 months ago

This is likely a very minor issue. I successfully built inchi-1 1.07-beta.3 binary on Debian Bookworm (Raspberry Pi 5, aarch64) via the following:

cd InChI-1.07-beta.3/INCHI-1-SRC/INCHI_EXE/inchi-1/gcc
make

Then, running the binary (i.e., ./inchi-1), reports the following:

InChI version 1, Software v. 1.07 (inchi-1 executable)
Linux 32-bit Build (gcc 12.2.0) of Mar  4 2024 17:24:59 
...
...

However, inspecting the ./inchi-1 with file outputs:

file ./inchi-1
./inchi-1: ELF 64-bit LSB pie executable, ARM aarch64....

So, I think the file is indeed a 64 bit binary, but the console print statement reporting 32 bit is incorrect. I tried the build with x86 and it correctly recognizes the build as 64 bit.

Thanks,

Vin

djb-rwth commented 3 months ago

Hi Vin, It looks as if aarch64 has not been considered whilst creating the output message regarding the OS. I will add it in soon-to-be-released 1.07-Beta4 and kindly ask you to re-test this again. Thank you in advance.

djb-rwth commented 3 months ago

Hi Vin, v.1.07-Beta4 has been uploaded, so please check if the issue has been resolved. Thank you.

vfscalfani commented 3 months ago

Okay, I just built from the main branch and it now correctly reports a 64 bit build on aarch64. Thanks for the fix!

djb-rwth commented 3 months ago

Thanks for your time and effort in checking this.

JanCBrammer commented 3 months ago

@djb-rwth, could you link the commit that closes this issue?