search

IUPAC-InChI / InChI

Main InChI repository
https://iupac-inchi.github.io/InChI-Web-Demo/
MIT License
69 stars 9 forks source link

allow customization of test library path location #49

Closed giallu closed 3 months ago

giallu commented 3 months ago

this adds a new --library-path command line argument, when set it will override the default logic for setting the library file path

giallu commented 3 months ago

Thanks for the PR, I like the approach. I took it a bit further and removed inchi_version from config_models.TestConfig in favor of inchi_library_path. Removing inchi_version means that we no longer need to hard-code the path to the library in run_tests.py.

Cool, thas was actually one thing I was going to suggest

Note that the CI failure is not related to the changes in this PR, it's something I need to address separately. I need to properly identify the triggering branch:

https://github.com/IUPAC-InChI/InChI/blob/33d90f7a9f8da07596d20f68ffb7df2b2779e32e/.github/actions/compile_inchi_lib/action.yaml#L16

That's probably because that ref is not actually in InChI's repo, but just in my fork.